Skip to content

Don't attach Suggests package in test #5420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2023
Merged

Don't attach Suggests package in test #5420

merged 1 commit into from
Sep 18, 2023

Conversation

MichaelChirico
Copy link
Contributor

Doing so makes tests less hermetic since library() has permanent side effects (of course, loadNamespace() does too, but generally less serious).

teunbrand
teunbrand approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@teunbrand teunbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This looks good to me

@teunbrand teunbrand merged commit eb920af into tidyverse:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teunbrand teunbrand teunbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelChirico @teunbrand