New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resubmission of #823 #952

Merged
merged 3 commits into from Jun 18, 2015

Conversation

Projects
None yet
2 participants
@BrianDiggs
Contributor

BrianDiggs commented Apr 24, 2014

Resubmission of #823

BrianDiggs added some commits Jun 21, 2013

Fix for last small segment in polar coordinate munching being dropped
When in polar coordinates, when the last segment to be drawn
was short enough that it did not require any interpolation,
the segment was not drawn because the munch_data code did not
include the last (second) point of the segment.

Better calculation of how many segments the segment should
be interpolated into.

Put in a missing drop=FALSE when subsetting a data.frame because
there may be only a single column (which would then not be
assembled with the rest of the data properly).

Fixed interp so that the code matches the documentation. Also
clarified the documentation.

Wrote test code to exercise interp and munch_data
Fix for last small segment in polar coordinate munching being dropped
Resubmission of #823

When in polar coordinates, when the last segment to be drawn
was short enough that it did not require any interpolation,
the segment was not drawn because the munch_data code did not
include the last (second) point of the segment.

Better calculation of how many segments the segment should
be interpolated into.

Put in a missing drop=FALSE when subsetting a data.frame because
there may be only a single column (which would then not be
assembled with the rest of the data properly).

Fixed interp so that the code matches the (internal) documentation.
Also clarified the documentation.

Wrote test code to exercise interp and munch_data
@hadley

This comment has been minimized.

Member

hadley commented Jun 11, 2015

Could you please merge/rebase, checking the position of the NEWS bullet?

@hadley hadley merged commit 3084fc3 into tidyverse:master Jun 18, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@hadley

This comment has been minimized.

Member

hadley commented Jun 18, 2015

Merged by hand - thanks!

@BrianDiggs

This comment has been minimized.

Contributor

BrianDiggs commented Jun 18, 2015

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment