Skip to content

glimpse() may not dispatch properly to type_sum() #185

Closed
#186
Closed
glimpse() may not dispatch properly to type_sum()#185
#186
Labels
bugan unexpected problem or unintended behaviorprinting 🖨️
Milestone
1.3.0

Description

@dholstius
dholstius
opened on Oct 31, 2016

Hi, thanks for all your work on tibble!

Here's an example of a simple problem. I'm about to try and submit a pull request.

CY <- function (x) {
  stopifnot(is.numeric(x))
  structure(as.integer(x), class = "CY")
}

as.character.CY <- function (from) {
  paste0(class(from), unclass(from))
}

library(tibble)

df <- tibble(cal_yr = CY(2011:2013), 
             budget = c(100, 200, 150))

type_sum.CY <- function (x, ...) {
  "CY"
}

glimpse(df)
lapply(df, class)

Activity

  1. dholstius
    added a commit that references this issue on Oct 31, 2016

    Derive classes and names from `x` not `df`

    fc87167
  2. krlmlr
    added
    bugan unexpected problem or unintended behavior
    printing 🖨️
    on Jan 4, 2017
  3. krlmlr
    added this to the 1.3.0 milestone on Jan 4, 2017
  4. krlmlr
    closed this as completedin #186on Jan 4, 2017
  5. krlmlr
    added 2 commits that reference this issue on Jan 4, 2017

    Merge branch 'b-#185-glimpse-type_sum'. Closes #186.

    edcc104

    Merge tag 'v1.2-14'

    81ea956
  6. krlmlr
    added a commit that references this issue on Apr 1, 2017

    Merge tag 'v1.3.0'

    797d711

  7. github-actions commented on Dec 14, 2020

    @github-actions
    github-actionsbot
    on Dec 14, 2020
    Contributor

    This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

  8. github-actions
    locked and limited conversation to collaborators on Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugan unexpected problem or unintended behaviorprinting 🖨️

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions