glimpse() may not dispatch properly to type_sum() #185

dholstius · 2016-10-31T20:14:33Z

Hi, thanks for all your work on tibble!

Here's an example of a simple problem. I'm about to try and submit a pull request.

CY <- function (x) {
  stopifnot(is.numeric(x))
  structure(as.integer(x), class = "CY")
}

as.character.CY <- function (from) {
  paste0(class(from), unclass(from))
}

library(tibble)

df <- tibble(cal_yr = CY(2011:2013), 
             budget = c(100, 200, 150))

type_sum.CY <- function (x, ...) {
  "CY"
}

glimpse(df)
lapply(df, class)

The text was updated successfully, but these errors were encountered:

`as.data.frame` may drop classes from `x` when creating `df`. See tidyverse#185 for reprex.

- `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius).

@kwstat

- `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius). - Reword documentation for `tribble()` (#191, @kwstat). - Unicode multiplication sign is rendered as `x` if it cannot be represented in the current locale (#192, @ncarchedi).

@ncarchedi

Bug fixes ========= - Time series matrices (objects of class `mts` and `ts`) are now supported in `as_tibble()` (#184). - The `all_equal()` function (called by `all.equal.tbl_df()`) now forwards to `dplyr` and fails with a helpful message if not installed. Data frames with list columns cannot be compared anymore, and differences in the declared class (`data.frame` vs. `tbl_df`) are ignored. The `all.equal.tbl_df()` method gives a warning and forwards to `NextMethod()` if `dplyr` is not installed; call `all.equal(as.data.frame(...), ...)` to avoid the warning. This ensures consistent behavior of this function, regardless if `dplyr` is loaded or not (#198). Interface changes ================= - Now requiring R 3.1.0 instead of R 3.1.3 (#189). - Add `as.tibble()` as an alias to `as_tibble()` (#160, @LaDilettante). - New `frame_matrix()`, similar to `frame_data()` but for matrices (#140, #168, @LaDilettante). - New `deframe()` as reverse operation to `enframe()` (#146, #214). - Removed unused dependency on `assertthat`. Features ======== General ------- - Keep column classes when adding row to empty tibble (#171, #177, @LaDilettante). - Singular and plural variants for error messages that mention a list of objects (#116, #138, @LaDilettante). - `add_column()` can add columns of length 1 (#162, #164, @LaDilettante). Input validation ---------------- - An attempt to read or update a missing column now throws a clearer warning (#199). - An attempt to call `add_row()` for a grouped data frame results in a helpful error message (#179). Printing -------- - Render Unicode multiplication sign as `x` if it cannot be represented in the current locale (#192, @ncarchedi). - Backtick `NA` names in printing (#206, #207, @jennybc). - `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius). - The `max.print` option is ignored when printing a tibble (#194, #195, @t-kalinowski). Documentation ============= - Fix typo in `obj_sum` documentation (#193, @etiennebr). - Reword documentation for `tribble()` (#191, @kwstat). - Now explicitly stating minimum Rcpp version 0.12.3. Internal ======== - Using registration of native routines.

github-actions · 2020-12-14T00:42:08Z

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

dholstius added a commit to dholstius/tibble that referenced this issue Oct 31, 2016

Derive classes and names from x not df

fc87167

`as.data.frame` may drop classes from `x` when creating `df`. See tidyverse#185 for reprex.

dholstius mentioned this issue Oct 31, 2016

Derive classes and names from x not df #186

Merged

krlmlr added bug an unexpected problem or unintended behavior printing 🖨️ labels Jan 4, 2017

krlmlr added this to the 1.3.0 milestone Jan 4, 2017

krlmlr closed this as completed in #186 Jan 4, 2017

krlmlr added a commit that referenced this issue Jan 4, 2017

Merge branch 'b-#185-glimpse-type_sum'. Closes #186.

edcc104

- `glimpse()` now uses `type_sum()` also for S3 objects (#185, #186, @holstius).

github-actions bot locked and limited conversation to collaborators Dec 14, 2020

glimpse() may not dispatch properly to type_sum() #185

glimpse() may not dispatch properly to type_sum() #185

dholstius commented Oct 31, 2016

github-actions bot commented Dec 14, 2020

glimpse() may not dispatch properly to type_sum() #185

glimpse() may not dispatch properly to type_sum() #185

Comments

dholstius commented Oct 31, 2016

github-actions bot commented Dec 14, 2020