New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nest #158

Merged
merged 4 commits into from Feb 3, 2016

Conversation

Projects
None yet
2 participants
@joshkatz
Contributor

joshkatz commented Jan 24, 2016

Seem to be getting some unexpected behavior in nest:

df <- data.frame(x = 1:3, y = c("B", "A", "A"))
tidyr::nest(df, x)
#      y data   
#1    B 2, 3
#2    A    1

Made a small change to nest_impl, and added a unit test.

@hadley

This comment has been minimized.

Member

hadley commented Feb 3, 2016

Thanks! Can you please add a bullet point to NEWS?

@joshkatz

This comment has been minimized.

Contributor

joshkatz commented Feb 3, 2016

Sure thing. Added.

hadley added a commit that referenced this pull request Feb 3, 2016

Merge pull request #158 from joshkatz/master
Fix nest ordering issue. 

Fixes #160

@hadley hadley merged commit 5f4c39b into tidyverse:master Feb 3, 2016

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@hadley

This comment has been minimized.

Member

hadley commented Feb 3, 2016

Awesome, thanks Josh!

@joshkatz

This comment has been minimized.

Contributor

joshkatz commented Feb 4, 2016

No problem, happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment