Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pseudo occulusion): fix out of range access #1294

Merged
merged 1 commit into from
May 15, 2024

Conversation

yuki-takagi-66
Copy link

Description

地図にないpolygonIDを指定すると例外をキャッチできずノードが死ぬ問題の修正です。

Tests performed

適当な番号999999とかをいれたり、お台場の地図で動かして、弾けることを確認しました。
また、作動してほしい場所での動作に影響がないことを確認しました。

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Copy link

@mkuri mkuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuri mkuri merged commit 61ab202 into beta/v0.19.1 May 15, 2024
11 of 13 checks passed
@mkuri mkuri deleted the fix/pseudo_occulusion/suppress_out_of_range branch May 15, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants