Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsafe recovery: Fix learner nodes got ignored in auto detect mode error (#6691) #6710

Closed
wants to merge 1 commit into from
Closed

unsafe recovery: Fix learner nodes got ignored in auto detect mode error (#6691) #6710

wants to merge 1 commit into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6691

What problem does this PR solve?

Issue Number: Close #6690

What is changed and how does it work?

Fix learner nodes got ignored in auto detect mode error

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

This PR does not need to be cherry-picked into release 6.5, since the customized PR #6683 will be.

Release note

None.

@v01dstar @ti-chi-bot @ti-chi-bot
unsafe recovery: Fix learner nodes got ignored in auto detect mode er…
c2aaf20 
…ror (tikv#6691)

ref tikv#6683, close tikv#6690

Fix learner nodes got ignored in auto detect mode error

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 29, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jun 29, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and lhy1024 June 29, 2023 01:17
@v01dstar v01dstar mentioned this pull request Jul 3, 2023
Merged
@v01dstar
Copy link
Contributor

v01dstar commented Jul 3, 2023

Manual cherry-pick : #6744

@HuSharp
Copy link
Member

HuSharp commented Jul 4, 2023

Manual cherry-pick : #6744

Why recreate a manual pr？ @v01dstar

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 4, 2023
@nolouch nolouch closed this Jul 4, 2023
ti-chi-bot bot added a commit that referenced this pull request Jul 5, 2023
@v01dstar @ti-chi-bot
unsafe recovery: Fixing learner store being ignored error in 7.1 (#6744)
9954576 
ref #6690, ref #6710

Fix learner store/ replica being ignored error in auto detect mode.

Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2023
Closed
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jul 5, 2023
@v01dstar @ti-chi-bot
This is an automated cherry-pick of tikv#6744
b541e10 
ref tikv#6690, ref tikv#6710

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2023
Closed
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing Awaiting requested review from disksing

@lhy1024 lhy1024 Awaiting requested review from lhy1024

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @v01dstar @HuSharp @nolouch