unsafe recovery: Fixing learner store being ignored error in 7.1

[v01dstar]

What problem does this PR solve?

Issue Number: Ref #6690

What is changed and how does it work?

Fix learner store/ replica being ignored error in auto detect mode.

Check List

Tests

• Unit test

Code changes

Side effects

Related changes

• Original cherry-pick proposed by Ti-Chi bot but with merge conflicts: unsafe recovery: Fix learner nodes got ignored in auto detect mode error (#6691) #6710

Release note

None.

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• Connor1996
• nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[v01dstar]

/cc @Connor1996

[Connor1996]

LGTM

[nolouch]

/merge

[ti-chi-bot]

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: f1733d4

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (2164c07) 74.92% compared to head (275a55d) 75.00%.

Additional details and impacted files

@@               Coverage Diff               @@
##           release-7.1    #6744      +/-   ##
===============================================
+ Coverage        74.92%   75.00%   +0.07%     
===============================================
  Files              407      407              
  Lines            40754    40752       -2     
===============================================
+ Hits             30534    30565      +31     
+ Misses            7546     7526      -20     
+ Partials          2674     2661      -13     

Flag	Coverage Δ
unittests	75.00% <ø> (+0.07%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/cluster/unsafe_recovery_controller.go	82.90% <ø> (+0.28%)	⬆️

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.1: #6762.

[ti-chi-bot]

In response to a cherrypick label: new pull request created to branch release-6.5: #6763.

[ti-chi-bot]

In response to a cherrypick label: base branch (release-7.1) needs to differ from target branch (release-7.1).