Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unsafe recovery: Fixing learner store being ignored error in 7.1 (#6744) #6763

Closed
wants to merge 1 commit into from
Closed

unsafe recovery: Fixing learner store being ignored error in 7.1 (#6744) #6763

wants to merge 1 commit into from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6744

What problem does this PR solve?

Issue Number: Ref #6690

What is changed and how does it work?

Fix learner store/ replica being ignored error in auto detect mode.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None.

@v01dstar @ti-chi-bot
Fix unsafe recovery bug in 7.1
877e455 
Signed-off-by: Yang Zhang <yang.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 5, 2023
Merged
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jul 5, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Jul 5, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 5, 2023
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx July 5, 2023 12:09
@nolouch
Copy link
Contributor

nolouch commented Jul 11, 2023

duplicated with https://github.com/tikv/pd/pull/6683/files

@nolouch nolouch closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhy1024 lhy1024 Awaiting requested review from lhy1024

@rleungx rleungx Awaiting requested review from rleungx

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @nolouch @v01dstar