raftstore: fix online config change panic for periodic-full-compact-start-time #17069

SpadeA-Tang · 2024-05-27T08:51:14Z

What is changed and how it works?

Issue Number: Close #17066

What's Changed:

fix online config change panic for periodic-full-compact-start-time

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Release note

None

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

ti-chi-bot · 2024-05-27T08:51:16Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

Connor1996
LykxSassinator

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

SpadeA-Tang · 2024-05-27T09:21:00Z

@afeinberg PTAL

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

LykxSassinator

LGTM

overvenus · 2024-05-28T05:19:55Z

src/config/mod.rs

+            let schedule = v.parse::<ReadableSchedule>()?;
+            ConfigValue::from(schedule)
+        }
+        ConfigValue::Skip | ConfigValue::None | ConfigValue::Module(_) => unreachable!(),


How about logging and returning an error?

ConfigValue::Skip | ConfigValue::None | ConfigValue::Module(_) will and should not be reached. I think it's fine as unlike the previous _ => unreachable!(), which may forget to implement some type, it is intentional.

Connor1996

LGTM

SpadeA-Tang · 2024-05-28T05:36:03Z

/merge

ti-chi-bot · 2024-05-28T05:36:05Z

@SpadeA-Tang: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2024-05-28T05:36:08Z

This pull request has been accepted and is ready to merge.

Commit hash: 4dc5ed9

…tart-time (tikv#17069) close tikv#17066 fix online config change panic for periodic-full-compact-start-time Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Signed-off-by: wuhuizuo <wuhuizuo@126.com>

…tart-time (tikv#17069) close tikv#17066 fix online config change panic for periodic-full-compact-start-time Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

* build: bump tikv pkg version (#17063) Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> * resolved_ts: refactor log for the unexpected path (#17064) (#17068) ref #16818 Refactor logs for the unexpected path, print both the exsiting row and input key/value. Signed-off-by: cfzjywxk <lsswxrxr@163.com> Co-authored-by: cfzjywxk <lsswxrxr@163.com> * chore: add prow OWNERS files for critial configuration files (#17071) (#17108) close #17004 Signed-off-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> * OWNERS: Auto Sync OWNERS files from community membership (#16973) (#17120) Signed-off-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Signed-off-by: Jinpeng Zhang <zzzhangjinpeng@gmail.com> Co-authored-by: Jinpeng Zhang <zzzhangjinpeng@gmail.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> * In-memory engine: strip off read related code from engine.rs to a separte file (#16792) ref #16141 strip off read related code from engine.rs to a separte file Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: collector iteration related metrics (#16735) ref #16141 collector iteration related metrics Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: expose range cache engine configuration (#16791) ref #16141 expose range cache engine configuration Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: do not load a range overlapped with an unresolved range (#16794) ref #16141 do not load a range overlapped with an unresolved range Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * server/node: rename Node to MultiRaftServer (#16783) close #16782 Signed-off-by: zhangjinpeng87 <zzzhangjinpeng@gmail.com> Signed-off-by: Jinpeng Zhang <zzzhangjinpeng@gmail.com> Co-authored-by: lucasliang <nkcs_lykx@hotmail.com> * In-memory engine: add metrics for memory usage (#16822) ref #16141 add metrics for memory usage Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: Jinpeng Zhang <zzzhangjinpeng@gmail.com> * In-memory engine: add metrics for gc duration, range load duration, and write duration (#16831) ref #16141 add metrics for gc duration, range load duration, and write duration Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: delete lock physically rather than writting tombstone (#16852) ref #16141 delete lock physically rather than writting tombstone Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: fix missing memory record when snapshot loading (#16850) ref #16141 fix missing memory record when snapshot loading Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-Memory Engine: add a tag to the range for easier troubleshooting (#16816) ref #16141 In-Memory Engine: add a tag into Range for diagnostics Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Signed-off-by: Qi Xu <tonyxuqqi@outlook.com> Co-authored-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: Qi Xu <tonyxuqqi@outlook.com> * In-memory engine: remove out of date pending ranges (#16872) ref #16141 remove out of date pending ranges Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * compile memory-engine by default and support dynamic config update for memory-engine (#16897) ref #16141 compile the in-memory-engine by default and support dynamic config update for memory-engine. The enabled flag would support enabled:true -> enabled:false and soft/hard limit also supports online change. But if enabled:false is set initially, the config change to make enabled:true needs the TiKV restart. Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com> * In-memory engine: skiplist tombstone should be handled separetely in gc (#16944) ref #16141 skiplist tombstone should be handled separetely in gc Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: manually implement partial_eq for CacheRange to avoid the consideration of tag (#16959) ref #16141 manually implement partial_eq for CacheRange to avoid the consideration of tag Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com> * In-memory engine: implement core local array and collect read flow statistics (#16945) ref #16141 implement core local array and collect read flow statistics Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: fix seek does not set self.valid properly (#16991) ref #16141 fix seek does not set self.valid properly Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * In-memory engine: add metrics for different types of iteration operations (#16997) ref #16141 add metrics for different types of iteration operations Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: add metrics for range count (#16971) ref #16141 add metrics for range count Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Signed-off-by: Spade A <71589810+SpadeA-Tang@users.noreply.github.com> Co-authored-by: lucasliang <nkcs_lykx@hotmail.com> * In-memory engine: fix gc worker not used (#17032) ref #16141 fix gc worker not used Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * raftstore: fix online config change panic for periodic-full-compact-start-time (#17069) close #17066 fix online config change panic for periodic-full-compact-start-time Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * config: test +HHMM offset in ReadableSchedule (#17081) close #17080 * Test both formats +HHMM offsets and as well as +HH:MM for ReadableSchedule. Signed-off-by: Alex Feinberg <alex@strlen.net> * In-memory engine: mvcc keys with different sequence number should only be handled once in GC (#17083) ref #16141, close #17060 mvcc keys with different sequen number should only be handled once in GC Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Signed-off-by: Spade A <71589810+SpadeA-Tang@users.noreply.github.com> Co-authored-by: Neil Shen <overvenus@gmail.com> Co-authored-by: lucasliang <nkcs_lykx@hotmail.com> * In-memory engine: enable compaction filter for HybridEngine (#17087) ref #16141, close #17086 enable compaction filter for HybridEngine Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * In-memory Engine: sequence number should be increased for each key (#17122) ref #16141, close #17114 sequence number should be increased for each key Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: support changing the direction of iteration (#17129) ref #16141, close #17079 support reverse direction when iterating Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * In-memory engine: clean lock cf tombstone in a background worker (#17128) ref #16141, close #17127 clean lock cf tombstone in a background worker Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory Engine: encode internal key trailer in little endian. (#17125) close #17082 An internal key trailer is `(sequence_number << 8) | value_type as u64` and it should be encoded in little endian to be consistent with RocksDB. Signed-off-by: Neil Shen <overvenus@gmail.com> * In-memory engine: set boundries when gc (#17145) ref #16141, close #17143 set boundries when gc Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * In-memory engine: encode key for lock cf without mvcc version in delete range (#17142) ref #16141, close #17140 encode key for lock cf without mvcc version in delete range Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * In-memory Engine: get GC safe_point from PD (#17144) close #17123 The `safe_point` is used to check if a cache is eligible to serve a read request. If the `safe_point` drifts into the future, for example by 10 minutes, the cache will not be able to serve any requests for those 10 minutes. This commit fixes such issue by getting the `safe_point` from PD. Signed-off-by: Neil Shen <overvenus@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * In-Memory Engine: Eviction, Algorithmic loading (#17023) ref #16141, ref #16764 In-Memory Engine: Algorithmic Load and Eviction Signed-off-by: Alex Feinberg <alex@strlen.net> * In-memory engine: consider range overlaps when eviction (#17137) ref #16141, close #17131 consider range overlaps when eviction Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: support delete range (#17151) ref #16141 support delete range Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: evict range should consider loading range (#17154) close #17153 evict range should consider loading range Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * In-memory engine: clear write batch when range load failed (#17156) ref #16141, close #17103 clear write batch when range load failed Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: fix concurrency issue between delete range and write to memory (#17149) close #17104 fix concurrency issue between delete range and write to memory Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * In-memory engine: add seek duration metrics (#17160) ref #16141 add seek duration metrics Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: add metrics for prepare for write duration (#17161) ref #16141 add metrics for prepare for write duration Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: set disk engine when start (#17165) ref #16141 set disk engine when start Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> * In-memory engine: avoid using snapshot cache (#16863) ref #16141 avoid using snapshot cache Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: evict range after some raft commands (#17159) ref #16141 evict range when becomeing follower, merge, and deleting data ranges. Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * In-memory engine: `filter` plus one when any key is removed during GC (#17171) ref #16141 filter plus one when any key is removed during GC Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Signed-off-by: Spade A <71589810+SpadeA-Tang@users.noreply.github.com> * periodic reload Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * avoid mem negative Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * make period of reload config Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * add overhead for delte entry size Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> * Fix missing field reload_period Signed-off-by: Neil Shen <overvenus@gmail.com> * Fix get_regions_in_range and BackgroundWorker compile Signed-off-by: Neil Shen <overvenus@gmail.com> --------- Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au> Signed-off-by: tonyxuqqi <tonyxuqi@outlook.com> Signed-off-by: Alex Feinberg <alex@strlen.net> Signed-off-by: Neil Shen <overvenus@gmail.com> Signed-off-by: Spade A <71589810+SpadeA-Tang@users.noreply.github.com> Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io> Co-authored-by: cfzjywxk <lsswxrxr@163.com> Co-authored-by: wuhuizuo <wuhuizuo@126.com> Co-authored-by: Jinpeng Zhang <zzzhangjinpeng@gmail.com> Co-authored-by: Spade A <71589810+SpadeA-Tang@users.noreply.github.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: lucasliang <nkcs_lykx@hotmail.com> Co-authored-by: tonyxuqqi <tonyxuqi@outlook.com> Co-authored-by: SpadeA-Tang <u6748471@anu.edu.au> Co-authored-by: Qi Xu <tonyxuqqi@outlook.com> Co-authored-by: Alex Feinberg <alex@strlen.net>

ti-chi-bot · 2024-07-26T07:45:36Z

In response to a cherrypick label: new pull request could not be created: failed to create pull request against tikv/tikv#release-8.1 from head ti-chi-bot:cherry-pick-17069-to-release-8.1: the GitHub API request returns a 403 error: {"message":"You have exceeded a secondary rate limit and have been temporarily blocked from content creation. Please retry your request again later. If you reach out to GitHub Support for help, please include the request ID 8AAC:12E1BA:5C7486:AFE6CF:66A3541F and timestamp 2024-07-26 07:45:35 UTC.","documentation_url":"https://docs.github.com/rest/overview/rate-limits-for-the-rest-api#about-secondary-rate-limits","status":"403"}

close tikv#17066 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

Connor1996 · 2024-07-31T08:30:35Z

/cherry-pick release-8.1

close tikv#17066 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-07-31T08:31:18Z

@Connor1996: new pull request created to branch release-8.1: #17335.

In response to this:

/cherry-pick release-8.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…tart-time (#17069) (#17335) close #17066 fix online config change panic for periodic-full-compact-start-time Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

…tart-time (tikv#17069) (tikv#17335) close tikv#17066 fix online config change panic for periodic-full-compact-start-time Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Signed-off-by: RidRisR <79858083+RidRisR@users.noreply.github.com>

init

f2c6db0

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2024

update

995606d

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

Merge branch 'master' into fix-tikv-ctl-panic

ce9dbf4

update

4dc5ed9

Signed-off-by: SpadeA-Tang <u6748471@anu.edu.au>

LykxSassinator reviewed May 27, 2024

View reviewed changes

LykxSassinator approved these changes May 27, 2024

View reviewed changes

ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. and removed do-not-merge/needs-triage-completed labels May 27, 2024

ti-chi-bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 28, 2024

overvenus reviewed May 28, 2024

View reviewed changes

Connor1996 approved these changes May 28, 2024

View reviewed changes

ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 28, 2024

Connor1996 removed the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 28, 2024

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 28, 2024

ti-chi-bot bot merged commit f302b9d into tikv:master May 28, 2024
6 of 7 checks passed

ti-chi-bot bot added this to the Pool milestone May 28, 2024

ti-chi-bot added the needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. label Jul 26, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 26, 2024

This is an automated cherry-pick of tikv#17069

df1dab1

close tikv#17066 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Jul 31, 2024

This is an automated cherry-pick of tikv#17069

d1e760a

close tikv#17066 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Jul 31, 2024

raftstore: fix online config change panic for periodic-full-compact-start-time (#17069) #17335

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

raftstore: fix online config change panic for periodic-full-compact-start-time #17069

raftstore: fix online config change panic for periodic-full-compact-start-time #17069

SpadeA-Tang commented May 27, 2024 •

edited

Loading

ti-chi-bot bot commented May 27, 2024 •

edited

Loading

SpadeA-Tang commented May 27, 2024

LykxSassinator left a comment

overvenus May 28, 2024

SpadeA-Tang May 28, 2024

Connor1996 left a comment

SpadeA-Tang commented May 28, 2024

ti-chi-bot bot commented May 28, 2024

ti-chi-bot bot commented May 28, 2024

ti-chi-bot commented Jul 26, 2024

Connor1996 commented Jul 31, 2024

ti-chi-bot commented Jul 31, 2024

raftstore: fix online config change panic for periodic-full-compact-start-time #17069

raftstore: fix online config change panic for periodic-full-compact-start-time #17069

Conversation

SpadeA-Tang commented May 27, 2024 • edited Loading

What is changed and how it works?

Related changes

Check List

Release note

ti-chi-bot bot commented May 27, 2024 • edited Loading

SpadeA-Tang commented May 27, 2024

LykxSassinator left a comment

Choose a reason for hiding this comment

overvenus May 28, 2024

Choose a reason for hiding this comment

SpadeA-Tang May 28, 2024

Choose a reason for hiding this comment

Connor1996 left a comment

Choose a reason for hiding this comment

SpadeA-Tang commented May 28, 2024

ti-chi-bot bot commented May 28, 2024

ti-chi-bot bot commented May 28, 2024

ti-chi-bot commented Jul 26, 2024

Connor1996 commented Jul 31, 2024

ti-chi-bot commented Jul 31, 2024

SpadeA-Tang commented May 27, 2024 •

edited

Loading

ti-chi-bot bot commented May 27, 2024 •

edited

Loading