Skip to content

Upgrade devDependencies #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2020
Merged

Upgrade devDependencies #312

merged 4 commits into from
Nov 6, 2020

Conversation

stefanpenner
Copy link
Contributor

@stefanpenner stefanpenner commented Nov 6, 2020 •
edited
Loading

Some custodial work, prior to continuing work on @rwjblue's open PRs.

This PR also appears to pass ember's test-suite when linked via

diff --git a/package.json b/package.json
index fd01de7a8..a81dd2b39 100644
--- a/package.json
+++ b/package.json
@@ -137,7 +137,7 @@
     "rollup-plugin-commonjs": "^9.3.4",
     "rollup-plugin-node-resolve": "^4.2.4",
     "route-recognizer": "^0.3.4",
-    "router_js": "^7.1.1",
+    "router_js": "link:/Users/spenner/src/tildeio/router.js/",
     "rsvp": "^4.8.5",
     "serve-static": "^1.14.1",
     "simple-dom": "^1.4.0",

Intent is to squash before merge

stefanpenner
stefanpenner commented Nov 6, 2020
View reviewed changes
lib/rsvp/index.d.ts
@@ -20,7 +20,7 @@ declare module 'rsvp' {
| ((value: T) => TResult1 | PromiseLike<TResult1>)
| undefined
| null;
export type OnRejected<T, TResult2> =
export type OnRejected<TResult2> =
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this T seem unused? What am i missing...

stefanpenner
stefanpenner commented Nov 6, 2020
View reviewed changes
@stefanpenner stefanpenner requested a review from rwjblue November 6, 2020 17:34
@stefanpenner
Copy link
Contributor Author

I've tested this ember.js, locally. This seems to be perfectly fine. If there is an issue, I will gladly revert + fix. Please let me know.

@stefanpenner stefanpenner merged commit cf669b3 into master Nov 6, 2020
@stefanpenner stefanpenner deleted the update-deps branch November 6, 2020 18:16
@rwjblue rwjblue changed the title upgrade deps Upgrade devDependencies Mar 4, 2021
@rwjblue rwjblue changed the title Upgrade devDependencies Upgrade devDependencies Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanpenner @rwjblue