Skip to content

Conversation

@ahammond
Copy link
Contributor

@ahammond ahammond commented Nov 7, 2025

Note

Apply a construct-wide RemovalPolicy aspect (default RETAIN) to all CloudFormation resources and update tests to validate behavior.

  • Aurora construct:
    • Introduces ApplyRemovalPolicyAspect and applies it via Aspects.of(this) to enforce removalPolicy across all CFN resources (defaults to RemovalPolicy.RETAIN).
    • Removes direct removalPolicy pass-through to aws_rds.DatabaseCluster.
    • Enhances AuroraProps.removalPolicy docs with explicit behavior.
  • Tests:
    • Add/expand tests to assert default Retain and explicit RETAIN/DESTROY/SNAPSHOT mapping on supported resources (AWS::RDS::DBCluster, AWS::RDS::DBInstance, AWS::SecretsManager::Secret, AWS::RDS::DBProxy).
    • Replace single-cluster policy assertion with template-wide checks.

Written by Cursor Bugbot for commit 71edd36. Configure here.

@ahammond ahammond self-assigned this Nov 7, 2025
@ahammond ahammond enabled auto-merge (squash) November 7, 2025 23:00
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.46%. Comparing base (dbe1df6) to head (78cb64c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
+ Coverage   96.41%   96.46%   +0.05%     
==========================================
  Files           6        6              
  Lines        1729     1756      +27     
  Branches      180      184       +4     
==========================================
+ Hits         1667     1694      +27     
  Misses         62       62              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ahammond ahammond merged commit e1efb33 into main Nov 8, 2025
12 checks passed
@ahammond ahammond deleted the retain_mode branch November 8, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants