iPXE build scripts update #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having the build_ipxe.sh handle running in docker or nix, we brake that out so that it is up to the user of build_ipxe.sh to get into a nix-shell. The script no longer calls docker or nix in any way. The purpose of this is to simplify the build process, adding features, maintainability, etc. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
This will work regardless of the location you runt the script from. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 5 5
Lines 437 437
=======================================
Hits 425 425
Misses 8 8
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
approved these changes
Sep 14, 2023
|
... I should probably review this, huh? It all looks good. Does it work on your machine? I get permission errors on mine. |
nshalman
approved these changes
Oct 3, 2023
Closed
|
Lets get this in to unblock #90. If there are more issues we can rectify post-merge. |
mergify bot
added a commit
that referenced
this pull request
Oct 4, 2023
## Description Switch the boot floppy to use GPT partitioning ## Why is this needed The GPT partition table allows us to label the partition more clearly which makes it easier for other tooling to detect / ignore it. ## How Has This Been Tested? Mostly just on my NixOS machine, though also under docker in #90 which is no longer needed thanks to #89 ## How are existing users impacted? What migration steps/scripts do we need? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update iPXE build scripts. Instead of having the
build_ipxe.shhandle running in docker or locally with nix, we remove all that out so that it is up to the user ofbuild_ipxe.shto get into a nix-shell usingbinary/script/shell.nix. The script no longer calls docker or nix to run the iPXE build. The purpose of this is to simplify the build process, adding features, maintainability, etc. This will also fix the build issue on main.Also updated the
golangci-lintto the latest version and resolve lint issues.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: