Floppy build fix #90
Closed
Floppy build fix #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nahum Shalman <nshalman@equinix.com>
Signed-off-by: Nahum Shalman <nshalman@equinix.com>
nshalman
force-pushed
the
floppy-build-fix
branch
from
8c88824
to
6e71813
Compare
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
=======================================
Coverage 97.25% 97.25%
=======================================
Files 5 5
Lines 437 437
=======================================
Hits 425 425
Misses 8 8
Partials 4 4 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Needs to be refactored after #89 lands. Most will not be needed. |
mergify bot
added a commit
that referenced
this pull request
Oct 4, 2023
## Description Switch the boot floppy to use GPT partitioning ## Why is this needed The GPT partition table allows us to label the partition more clearly which makes it easier for other tooling to detect / ignore it. ## How Has This Been Tested? Mostly just on my NixOS machine, though also under docker in #90 which is no longer needed thanks to #89 ## How are existing users impacted? What migration steps/scripts do we need? N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the build for the floppy image to properly use Nix and docker.
Why is this needed
The build is currently broken and it's all my fault.
How Has This Been Tested?
Tested on both a NixOS Linux machine and an x86 Mac.