This repository has been archived by the owner on Dec 31, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
add missing upload form $v.tar.gz.sha512sum #137
Merged
mmlb
merged 2 commits into
tinkerbell:master
from
MaxPeal:MaxPeal-upload-sha512sum-patch-1
Sep 28, 2020
Merged
add missing upload form $v.tar.gz.sha512sum #137
mmlb
merged 2 commits into
tinkerbell:master
from
MaxPeal:MaxPeal-upload-sha512sum-patch-1
Sep 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2020
mmlb
approved these changes
Sep 23, 2020
mmlb
suggested changes
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong button, meant to req changes
Signed-off-by: MaxPeal <30347730+MaxPeal@users.noreply.github.com> fix added echo
MaxPeal
force-pushed
the
MaxPeal-upload-sha512sum-patch-1
branch
from
September 28, 2020 10:49
21cee60
to
520cb7c
Compare
@mmlb done, |
in the continuous-integration/drone/pr drone i get an error: "Insufficient privileges to use volumes" |
mmlb
approved these changes
Sep 28, 2020
Thanks a lot @MaxPeal! |
MaxPeal
added a commit
to MaxPeal/osie
that referenced
this pull request
Sep 29, 2020
This reverts commit 38019b1.
This was referenced Sep 29, 2020
mergify bot
added a commit
that referenced
this pull request
Jun 28, 2021
## Description Follow up to #137 ## Why is this needed Also uploads checksum for latest.tar.gz if appropriate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upload latest.tar.gz.sha512sum and $v.tar.gz.sha512sum also to AWS
Why is this needed
To make it possibly to cache and verify the osie tar locally and skip a not needed new redownload
Fixes: #135
Slow or corrupt downloads
How Has This Been Tested?
Not tested as on my system its takes a half day!
How are existing users impacted? What migration steps/scripts do we need?
No impact for existing users.
Migration steps after this RP: add the logic for the sha512sum check to