Skip to content
This repository has been archived by the owner on Dec 31, 2021. It is now read-only.

add missing upload form $v.tar.gz.sha512sum #137

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

MaxPeal
Copy link
Contributor

@MaxPeal MaxPeal commented Sep 23, 2020

Description

Upload latest.tar.gz.sha512sum and $v.tar.gz.sha512sum also to AWS

Why is this needed

To make it possibly to cache and verify the osie tar locally and skip a not needed new redownload

Fixes: #135

Slow or corrupt downloads

How Has This Been Tested?

Not tested as on my system its takes a half day!

How are existing users impacted? What migration steps/scripts do we need?

No impact for existing users.

Migration steps after this RP: add the logic for the sha512sum check to

  • tink/setup.sh
  • tink/generate-envrc.sh
  • sandbox/setup.sh
  • sandbox/generate-envrc.sh

rules.mk.j2 Outdated Show resolved Hide resolved
Copy link
Contributor

@mmlb mmlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong button, meant to req changes

Signed-off-by: MaxPeal <30347730+MaxPeal@users.noreply.github.com>

fix added echo
@MaxPeal MaxPeal force-pushed the MaxPeal-upload-sha512sum-patch-1 branch from 21cee60 to 520cb7c Compare September 28, 2020 10:49
@MaxPeal MaxPeal requested a review from mmlb September 28, 2020 11:07
@MaxPeal
Copy link
Contributor Author

MaxPeal commented Sep 28, 2020

@mmlb done,
i done also a Merge branch with Mergify

@MaxPeal
Copy link
Contributor Author

MaxPeal commented Sep 28, 2020

in the continuous-integration/drone/pr drone i get an error: "Insufficient privileges to use volumes"
mybe a right problem for my user at drone.packet.net?

@mmlb mmlb merged commit 38019b1 into tinkerbell:master Sep 28, 2020
@mmlb
Copy link
Contributor

mmlb commented Sep 28, 2020

Thanks a lot @MaxPeal!

MaxPeal added a commit to MaxPeal/osie that referenced this pull request Sep 29, 2020
mergify bot added a commit that referenced this pull request Jun 28, 2021
## Description

Follow up to #137 

## Why is this needed

Also uploads checksum for latest.tar.gz if appropriate.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest.tar.gz.sha512sum files on AWS are missing.
2 participants