feat: Add component helper to xstate-component-tree package #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tivac
requested changes
Nov 19, 2021
Owner
tivac
left a comment
tivac
left a comment
There was a problem hiding this comment.
Looks good overall! Don't change the exports, we can adjust the package.json and build system instead I think.
src/component-tree.js
Outdated
| export default ComponentTree; | ||
| module.exports = ComponentTree; | ||
|
|
||
| exports.component = require("./component-helper.js"); |
Owner
There was a problem hiding this comment.
Instead of converting this module to commonjs let's leave it as-is, instead we can make some changes to package.json to expose this as import component from "xstate-component-tree/component-helper" for maximum tree-shaking support.
Preserves modules being ESM for authoring, but does a better job exposing everything. Also updated tests a bit to handle new export strategy.
tivac
approved these changes
Nov 23, 2021
BREAKING CHANGE: Need to `import { ComponentTree } from 'xstate-component-tree';` now.
Not supported until node@14
tivac
added a commit
that referenced
this pull request
Nov 24, 2021
Co-authored-by: Bradley Stafford <bstaffo@amazon.com> Co-authored-by: Pat Cavit <github@patcavit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Went ahead and put up a PR for this.
Obviously I might be missing some kinda coverage here in tests, the helpers for the test environment seemed really dense so I mostly sought out a copy/paste job to make a "okay this should just render the same as the test that renders with the
metatag.component-helper.jshelper.test.jsexport default ComponentTreeto commonjs because I couldn't find an easy way to support mixed exports