Ignore broken certificates when using n over ssl proxy #426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In wget there is already the "--no-check-certificate" option, but in curl it was missing. Added.
Pull Request Template:
Describe what you did
I added an additional param for curl that ignores invalid ssl certificates. Otherwise, the download fails and leaves a broken install behind.
How you did it
I tried to pull a newer version of node with
n latest
through an ssl proxy. Curl was complaining that the certificate was not valid - which is true for SSL proxies a.k.a. MITM.How to verify it doesn't effect the functionality of n
Fetching updates with a "normal" environment works flawlessly.