Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template:
Describe what you did
Added option for
--insecure
for working from behind a proxy which uses untrusted certificates.How you did it
Separate commits so can cherrypick if desired:
--insecure
option to n, and use it to disable certificate checks for curl/wget.NB: wget options are still insecure by default. However, this change hopefully removes an obstacle to changing the wget default options in the future.
How to verify it doesn't effect the functionality of n
Code inspection that this is a new code path and will not affect previous use cases.
If this solves an issue, please put issue in PR notes.
This option is partly to make it possible to use curl now when insecure is needed, and partly to allow making wget secure by default in future and bring it into line with curl.
Makes curl insecure opt-in, and not by default as suggested here: #323 #324 #426
Make wget secure by default in future: #475 #509
Other proxy related issues where
--insecure
could help: #284 #430 #503 #517If this solves an issue, please include the output of issue that had problems and then the fixed output from the same command.
Running a local proxy with MITM certificates to demonstrate:
Squash any unnecessary commits to keep history clean as possible
Place description for the changelog in PR so we can tally all changes for any future release
Added: --insecure option to disable certificate checks
[Suggested addition]
Note: if curl is not present and
n
is using wget, the certificate check has historically been disabled and that behaviour has not changed yet. In the future this may change (and you can add the--insecure
option now so will not be affected when it does change).