Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix insecure downloading of node-binaries for wget #475

Closed
wants to merge 1 commit into from
Closed

Fix insecure downloading of node-binaries for wget #475

wants to merge 1 commit into from

Conversation

norpol
Copy link

@norpol norpol commented Nov 17, 2017

♥

dskrvk
dskrvk reviewed Jan 17, 2018
View reviewed changes
Copy link

@dskrvk dskrvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'm not a maintainer.

@dskrvk dskrvk mentioned this pull request Jan 17, 2018
Closed
@norpol
Copy link
Author

norpol commented Jan 22, 2018

Thank you for bumping and linking to #426.

@norpol
Copy link
Author

norpol commented May 11, 2018

@troy0820 Could you check this out maybe?

@norpol
Copy link
Author

norpol commented May 19, 2018

Not interested in getting this merged anymore.
The only recommendation I would give anyone evaluating whether or not to use n is to checkout nodejs.org suggested methods. For example if you need something that is solving similar problems as n, checkout nvm or use your systems package manager (best solution from security aspect).

@norpol norpol closed this May 19, 2018
@norpol norpol deleted the patch-1 branch May 21, 2018 16:54
@shadowspawn shadowspawn mentioned this pull request Aug 12, 2018
Closed
@shadowspawn shadowspawn mentioned this pull request Jul 30, 2019
Closed
@shadowspawn
Copy link
Collaborator

shadowspawn commented Aug 3, 2019 •
edited
Loading

Prerelease available via npm i n@next for v6. Release notes: https://github.com/tj/n/releases/tag/6.0.0-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dskrvk dskrvk dskrvk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norpol @shadowspawn @dskrvk