Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameter `literal` to `Pane.send_keys` #121

Merged
merged 2 commits into from Jan 26, 2019

Conversation

Projects
None yet
4 participants
@ritiek
Copy link
Contributor

commented May 22, 2018

Closes #88.

This PR adds an optional parameter literal=False to Pane.send_keys which does not send keys to a tmux pane literally by default. When literal is set to True, it prefixes the send-keys command with -l parameter which allows sending keys literally.

@codecov-io

This comment has been minimized.

Copy link

commented May 22, 2018

Codecov Report

Merging #121 into master will decrease coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   79.49%   79.42%   -0.07%     
==========================================
  Files           8        8              
  Lines         863      865       +2     
==========================================
+ Hits          686      687       +1     
- Misses        177      178       +1
Impacted Files Coverage Δ
libtmux/pane.py 80.88% <75%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7027c...122d68e. Read the comment docs.

@tony tony force-pushed the tmux-python:master branch from e7720bc to 776245b Jun 23, 2018

@tony

This comment has been minimized.

Copy link
Member

commented Oct 14, 2018

@ritiek Can you rebase this (so the tests again?)

@ritiek ritiek force-pushed the ritiek:literal-keys branch from 786c831 to c1382b3 Oct 14, 2018

@ritiek

This comment has been minimized.

Copy link
Contributor Author

commented Oct 14, 2018

Rebased. :)

@Seanmatthews

This comment has been minimized.

Copy link

commented Nov 14, 2018

Seems the only error for this was a timeout? Can we rerun the test?

@ritiek ritiek closed this Nov 17, 2018

@ritiek ritiek reopened this Nov 17, 2018

@ritiek

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2018

Ok, they passed.

@tony

This comment has been minimized.

Copy link
Member

commented Jan 13, 2019

@ritiek Can we add a test for this?

@tony tony force-pushed the ritiek:literal-keys branch from c1382b3 to 2e2a77d Jan 26, 2019

@tony tony force-pushed the ritiek:literal-keys branch from 2e2a77d to 7b0222a Jan 26, 2019

@tony tony merged commit d98f346 into tmux-python:master Jan 26, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@tony

This comment has been minimized.

Copy link
Member

commented Jan 26, 2019

@ritiek merged! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.