Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start_directory to support to new sessions and panes #19

Merged
merged 1 commit into from Dec 20, 2016

Conversation

@gandelman-a
Copy link
Contributor

@gandelman-a gandelman-a commented Dec 19, 2016

This allows specifying start_directory for creation of both
session and panes.

Clarifies some docstrings as well.

This allows specifying start_directory for creation of both
session and panes.

Clarifies some docstrings as well.
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 19, 2016

Current coverage is 78.25% (diff: 66.66%)

Merging #19 into master will decrease coverage by 0.06%

@@             master        #19   diff @@
==========================================
  Files             8          8          
  Lines           812        814     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            636        637     +1   
- Misses          176        177     +1   
  Partials          0          0          

Powered by Codecov. Last update 5c227e6...5518068

@tony
Copy link
Member

@tony tony commented Dec 20, 2016

Looks good to me, 👍

@tony tony merged commit d991e69 into tmux-python:master Dec 20, 2016
1 of 3 checks passed
@tony
Copy link
Member

@tony tony commented Dec 20, 2016

@gandelman-a do you need this published ASAP? I can tag a new version w/ this PR

@gandelman-a
Copy link
Contributor Author

@gandelman-a gandelman-a commented Dec 20, 2016

Hi Tony, no.. thats fine. Just setting up some scripts for my dev. env. and running from master so its fine. Thanks!

@tony
Copy link
Member

@tony tony commented Dec 21, 2016

Understood. This got released in 0.6.1 too

@tony
Copy link
Member

@tony tony commented Dec 21, 2016

thanks for the contribution again @gandelman-a ! nicely done!

@haakenlid
Copy link

@haakenlid haakenlid commented Jan 12, 2017

tmux version 1.8 doesn't support the tmux new-session -c <start_directory> option. This caused an error in the tmuxp tests.

https://travis-ci.org/tony/tmuxp/jobs/190761397#L917
E LibTmuxException: [u'tmux: unknown option -- c', u'usage: new-session [-AdDP] [-F format] [-n window-name] [-s session-name] [-t target-session] [-x width] [-y height] [command]']

A possible workaround is to instead use default-path in tmux 1.8 (not supported in later versions) or to use subprocess to run something like this (cd $start_directory; tmux new-session -t $session_name), which should work in all versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants