Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failure of test_pane_order on fedora machines #109

Merged
merged 1 commit into from Jul 7, 2015

Conversation

@marbu
Copy link
Contributor

@marbu marbu commented Jul 5, 2015

This pull request fixes the following issue:

When I run unit tests of tmuxp from current master on a fedora machine, test test_pane_order fails like this:

======================================================================
FAIL: test_pane_order (tmuxp.testsuite.workspacebuilder.PaneOrderingTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/martin/projects/tmuxp/tmuxp/testsuite/workspacebuilder.py", line  711, in test_pane_order
    self.assertEqual(p.get('pane_current_path'), pane_path)
AssertionError: u'/usr/sbin' != u'/sbin'
- /usr/sbin
? ----
+ /sbin

This mismatch is likely caused by the fact that /sbin directory is just a link to /bin/sbin (see usr move feature. Since the primary purpose of this unit test is to check the order of panes , I propose to simply use different directory which is not a symlink.

tony added a commit that referenced this pull request Jul 7, 2015
fix failure of test_pane_order on fedora machines
@tony tony merged commit 413d7cb into tmux-python:master Jul 7, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tony
Copy link
Member

@tony tony commented Jul 7, 2015

@marbu Excellent, thank you!

@marbu marbu deleted the marbu:fix_test_pane_order branch Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.