Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add window_index option #31

Merged
merged 2 commits into from Dec 5, 2013
Merged

add window_index option #31

merged 2 commits into from Dec 5, 2013

Conversation

@stratoukos
Copy link

@stratoukos stratoukos commented Dec 5, 2013

Adds a window_index option so that you can specify a window's index.

This is very useful for me, since I like to have some windows that I don't interact a lot with (running servers or tailing log files) on the "right side" of the keyboard (indexes 8-9).

Stratos Moros
includes docs and tests
@tony
Copy link
Member

@tony tony commented Dec 5, 2013

@stratoukos Great work on this commit. One thing is missing, what about cases where base-index is set to 1 in ~/.tmux.conf?

======================================================================
FAIL: test_window_index (tmuxp.testsuite.test_workspacebuilder.WindowIndexTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tony/workspace/tmuxp/tmuxp/testsuite/test_workspacebuilder.py", line 500, in test_window_index
    self.assertEqual(window['window_index'], expected_index)
AssertionError: u'1' != '0'

----------------------------------------------------------------------
@stratoukos
Copy link
Author

@stratoukos stratoukos commented Dec 5, 2013

Yeah, this didn't cross my mind, since the test suite passed with my
configuration. The problem seems to be on the test case and not the
feature itself.

I'll look into it and follow up shortly.

On 5 Dec 2013, at 17:29, Tony Narlock wrote:

@stratoukos Great work on this commit. One thing is missing, what
about cases where base-index is set to 1 in ~/.tmux.conf?

======================================================================
FAIL: test_window_index 
(tmuxp.testsuite.test_workspacebuilder.WindowIndexTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File 
"/home/tony/workspace/tmuxp/tmuxp/testsuite/test_workspacebuilder.py", 
line 500, in test_window_index
 self.assertEqual(window['window_index'], expected_index)
AssertionError: u'1' != '0'

----------------------------------------------------------------------

Reply to this email directly or view it on GitHub:
#31 (comment)

@stratoukos
Copy link
Author

@stratoukos stratoukos commented Dec 5, 2013

This commit passes all test with any base-index for me.

tony added a commit that referenced this pull request Dec 5, 2013
add window_index option
@tony tony merged commit 95d6df9 into tmux-python:master Dec 5, 2013
1 check passed
1 check passed
default The Travis CI build passed
Details
@tony
Copy link
Member

@tony tony commented Dec 5, 2013

@stratoukos: Thank you. Merging this. I am going to bump to v0.1.0rc6 on pypi so we can get this tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.