New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two issues in cli #48

Merged
merged 2 commits into from Jan 28, 2014

Conversation

Projects
None yet
3 participants
@JorisE
Contributor

JorisE commented Jan 28, 2014

Trying out tmuxp I ran into two problems. Tmuxp freeze does not work in python3 and running tmuxp without an option raises an error. Hope this helps.

JorisE added some commits Jan 27, 2014

The prompt_choices function now returns a correct result.
The prompt_choices function would try to call string.ascii_lowercase(rv) where
rv is a string.
This would raise an error because ascii_lowercase is not a function. Assuming
that the intended result is a lowercase version of the string, this has been
changed to use rv.lower()

Also the check::
        if isinstance(string, basestring):
has been changed to::
        if type(string) is str:

because basestring is not defined in python3.
A check has been added to know if args has an attribute 'callback'.
If args has no attribute callback, the help text should be printed. Because
there was a check to::
        if args.callback is 'x':
It would raise an error before the parser.print_help() was reached.

tony added a commit that referenced this pull request Jan 28, 2014

Merge pull request #48 from JorisE/master
Fixed two issues in cli

@tony tony merged commit 07c1d3d into tmux-python:master Jan 28, 2014

1 check passed

default The Travis CI build passed
Details
@coveralls

This comment has been minimized.

coveralls commented Jan 28, 2014

Coverage Status

Coverage decreased (-0.04%) when pulling 6d92023 on JorisE:master into 33e293c on tony:master.

@tony

This comment has been minimized.

Member

tony commented Jan 28, 2014

@JorisE : Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment