Skip to content

Conversation

tony
Copy link
Member

@tony tony commented Jun 1, 2019

#491

Fixes #493

with tmpdir.as_cwd():
runner = CliRunner()
# Use tmux server (socket name) used in the test
cli_args = cli_args + ['-L', server.socket_name]
Copy link
Member Author

@tony tony Jun 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kstilwell

server is a pytest fixture for a randomly generated tmux session. In order to prevent it clobbering from any of the developer's sessions, it's ran on a custom socket name (via -L socket-name).

Off topic 1: technically it's also possible tmuxp tests could be run in parallel: tmuxp / libtmux respects socket name and socket path

Off topic 2: I created an issue at #495 to streamline freeze a bit more (not require entering the filename a second time)

@codecov-io
Copy link

codecov-io commented Jun 1, 2019

Codecov Report

Merging #494 into master will increase coverage by 3.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #494      +/-   ##
==========================================
+ Coverage   75.37%   78.76%   +3.39%     
==========================================
  Files           5        5              
  Lines         796      796              
  Branches      232      232              
==========================================
+ Hits          600      627      +27     
+ Misses        146      114      -32     
- Partials       50       55       +5
Impacted Files Coverage Δ
tmuxp/cli.py 64.65% <0%> (+8.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb984dd...e811caf. Read the comment docs.

@tony tony merged commit 7956070 into master Jun 1, 2019
@tony tony deleted the 491-test-example branch June 1, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reminder: Write test for #491
2 participants