Freeze config for attached session #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 75.97% 75.91% -0.07%
==========================================
Files 7 7
Lines 1174 1179 +5
Branches 304 306 +2
==========================================
+ Hits 892 895 +3
- Misses 200 201 +1
- Partials 82 83 +1
Continue to review full report at Codecov.
|
|
|
|
Sorry for the delay. That is my fault. Can you give this a rebase? The docs have since been moved to markdown here: https://github.com/tmux-python/tmuxp/blob/master/docs/cli.md |
will-ockmore
force-pushed
the
freeze_config_for_attached_session
branch
from
aeac96e
to
4785730
Compare
for more information, see https://pre-commit.ci
|
@tony no problem. I've moved the changes over to the new markdown docs, I've also signed the CLA 👍 |
|
@will-ockmore Taking a look now |
tony
added a commit
that referenced
this pull request
Jan 29, 2022
|
@will-ockmore Merged! This will ship in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behaviour of
tmuxp freezeto default to the currently attached session. It achieves this by modifying theget_sessionutility function, will has the side effect of also modifying the behaviour oftmuxp shellto match - as this is the behaviour specified in the docs I believe it's probably fine and was just a bug.Closes #659