Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeze config for attached session #660



Copy link

This PR changes the behaviour of tmuxp freeze to default to the currently attached session. It achieves this by modifying the get_session utility function, will has the side effect of also modifying the behaviour of tmuxp shell to match - as this is the behaviour specified in the docs I believe it's probably fine and was just a bug.

Closes #659

@will-ockmore will-ockmore self-assigned this Jan 12, 2021
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #660 (6c5ffe0) into master (97b7e8d) will decrease coverage by 0.06%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
- Coverage   75.97%   75.91%   -0.07%     
  Files           7        7              
  Lines        1174     1179       +5     
  Branches      304      306       +2     
+ Hits          892      895       +3     
- Misses        200      201       +1     
- Partials       82       83       +1     
Impacted Files Coverage Δ
tmuxp/ 85.26% <ø> (ø)
tmuxp/ 84.41% <71.42%> (-1.70%) ⬇️
tmuxp/ 73.31% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b7e8d...6c5ffe0. Read the comment docs.

Copy link

CLAassistant commented Jan 11, 2022

CLA assistant check
All committers have signed the CLA.

Copy link

tony commented Jan 29, 2022


Sorry for the delay. That is my fault.

Can you give this a rebase?

The docs have since been moved to markdown here:

@will-ockmore will-ockmore force-pushed the freeze_config_for_attached_session branch from aeac96e to 4785730 Compare January 29, 2022 13:56
Copy link
Contributor Author

@tony no problem. I've moved the changes over to the new markdown docs, I've also signed the CLA 👍

Copy link

tony commented Jan 29, 2022

@will-ockmore Taking a look now

@tony tony merged commit 5bfd582 into tmux-python:master Jan 29, 2022
Copy link

tony commented Jan 29, 2022

@will-ockmore Merged!

This will ship in the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

tmuxp freeze outputs configuration for first session, not currently attached session
3 participants