Builder: Use shutil.get_terminal_size()
#926
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in re: #667, #704, #737
Warning
This would definitely be breaking behavior.
Test instructions
Latest (1.46.0a0):
pipx install --suffix=@builder-sizes 'tmuxp >= 1.46.0a0'
Outdated:
pipx install --suffix=@builder-sizes 'tmuxp @ git+https://github.com/tmux-python/tmuxp.git@builder-sizes'
Then:
tmuxp@builder-sizes load ./path/to/file.yaml
In the configuration, use
options.main-pane-height
/options.main-pane-width
with or without percentage:You should see something like:
Video:
2024-04-07.12-38-33.-.tmuxp.-.pr.926.-.main-pane-height.mp4
Changes
[Builder] Use
shutil.get_terminal_size
This ensures the tmux builder obeys the terminal window's current dimensions.
CLI[Load] Remove layout hooks
These did not seem to be implemented correctly anyway, so will effectively be a noop.