Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need new Python version on PyPi #219

Open
HondoOhnaka opened this issue Mar 19, 2015 · 15 comments
Open

Need new Python version on PyPi #219

HondoOhnaka opened this issue Mar 19, 2015 · 15 comments

Comments

@HondoOhnaka
Copy link

I'm confused as it looks like this has been updated more recently than the "official" version fork by @salimfadhley . It looks like his fork has solved the missing init.py file for the python module.

But it has not been updated on PyPi since last June.

Can someone step up and address this and get the latest version bumped so it can be imported as a module?

Relates to: #140

@todbot
Copy link
Owner

todbot commented Mar 19, 2015

salim's version is the official one, this is just a mirror. As far as I know there's nothing new in this repo.

His version is only for Python 3 I think though.

@salimfadhley
Copy link
Contributor

I've not done any work on this in months - is there a specific change you need? I can have a go.

@franc0is
Copy link

franc0is commented Sep 5, 2015

@salimfadhley see #140. The library no longer works on python2 because of it. After pip install, import still fails:

+ ~/Work/francois-poneys/blink1 on master* $ python
Python 2.7.10 (default, Jun 10 2015, 19:42:47) 
[GCC 4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
+>>> import blink1
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named blink1

@salimfadhley
Copy link
Contributor

I have not played with this for ages - I can give it a once over sometime
this week.

On Sat, 5 Sep 2015 19:41 François Baldassari notifications@github.com
wrote:

@salimfadhley https://github.com/salimfadhley see #140
#140. The library no longer
works on python2 because of it. After pip install, import still fails:

  • ~/Work/francois-poneys/blink1 on master* $ python
    Python 2.7.10 (default, Jun 10 2015, 19:42:47)
    [GCC 4.2.1 Compatible Apple LLVM 6.1.0 (clang-602.0.53)] on darwin
    Type "help", "copyright", "credits" or "license" for more information.
    +>>> import blink1
    Traceback (most recent call last):
    File "", line 1, in
    ImportError: No module named blink1


Reply to this email directly or view it on GitHub
#219 (comment).

@jjshoe
Copy link

jjshoe commented Apr 19, 2016

getting bit by this as well :(

@todbot
Copy link
Owner

todbot commented Apr 19, 2016

hey @salimfadhley, I could make these changes if you point me at the basics of how to generate content for PyPi (or make me a contributor if PyPi supports such a concept, my PyPi id is 'todbot')

@jjshoe
Copy link

jjshoe commented Apr 19, 2016

An additional complication is he doesn't appear to have issues turned on for that repo?

@salimfadhley
Copy link
Contributor

Okay - I can make Todd the project owner and also do a release. It won't be
until late tonight.

Todd what is your username

On Tue, 19 Apr 2016 02:27 jjshoe, notifications@github.com wrote:

An additional complication is he doesn't appear to have issues turned on
for that repo?


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#219 (comment)

@todbot
Copy link
Owner

todbot commented Apr 19, 2016

Hi @salimfadhley, my PyPi username is "todbot".

@salimfadhley
Copy link
Contributor

Todd, you have been added as a project publisher.

I've just joined a team within Bank of America that's a keen user of Blink1
mk2 lights. I'm going to add my two to the collection and hopefully use
this as an excuse to improve our software.

Now remind me - whose version is the official version these days? My
preference would be to kill off my version of the software since I think
it's confusing to have somebody other than the blink1 company holding the
official version of the software.

Have you any idea what it is I'm supposed to be fixing. Sorry - totally out
of it! :-)

On Tue, 19 Apr 2016 at 07:30 Tod E. Kurt notifications@github.com wrote:

Hi @salimfadhley https://github.com/salimfadhley, my PyPi username is
"todbot".


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#219 (comment)

@todbot
Copy link
Owner

todbot commented Apr 20, 2016

Hi Salim,
No problem, I understand about lack of time!
I think there are two main issues:

  1. The version on PyPi is from your fork of this repo, but issues with that version come here, and
  2. This library is Python 3 only and many people want it to work with Python 2.

My questions to you are:

  1. Where is there a good doc on how to publish to PyPi?
  2. How hard is it to make this library work with Python 2?

Thanks!

@salimfadhley
Copy link
Contributor

I will make a script with all the publishing logic

Making if python compatible should be easy as long as the USB libraries ate
functionally the same.

On Wed, 20 Apr 2016 04:00 Tod E. Kurt, notifications@github.com wrote:

Hi Salim,
No problem, I understand about lack of time!

I think there are two main issues:

  1. The version on PyPi is from your fork of this repo, but issues with
    that version come here, and
  2. This library is Python 3 only and many people want it to work with
    Python 2.

My questions to you are:

  1. Where is there a good doc on how to publish to PyPi?
  2. How hard is it to make this library work with Python 2?

Thanks!


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#219 (comment)

@jklmnn
Copy link

jklmnn commented Jul 5, 2017

Is this still active?
There are several bugs in the python3 blink1 module from pypi that are fixed in this repo. Will there be an update in pypi?

@salimfadhley
Copy link
Contributor

salimfadhley commented Jul 5, 2017 via email

@jklmnn
Copy link

jklmnn commented Jul 7, 2017

Well the bugs I mean are all fixed in this repo. All that would be required is to update your repo with the contents of this one or use this one to create the pypi package (which I would prefer since this repo is also on the Blink1 library page).
EDIT: If you wan't to I can specifically point out the bugs I mean, but I think there might be more that doesn't affect me and that are also fixed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants