Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "The device does not support the specified langid" error #295

Merged
merged 1 commit into from
Jan 17, 2017

Conversation

pedronavf
Copy link
Contributor

In the latest PyUSB, usb.util.get_string no longer has a length argument (commit dac78933f6a6eaf5ae82f48e2f4e7d1733dc2f98) therefore it gets index as langid instead of None and fails.

In the latest PyUSB, usb.util.get_string no longer has a length argument (commit dac78933f6a6eaf5ae82f48e2f4e7d1733dc2f98) therefore it gets index as langid instead of None and fails.
@todbot todbot merged commit ac4014e into todbot:master Jan 17, 2017
@todbot
Copy link
Owner

todbot commented Jan 17, 2017

thanks!

@jnth
Copy link

jnth commented Jan 26, 2017

Thank you for this fix.
Could you release a new version on PyPi ? (relates to #219)

I think you can change (in python/pypi/setup.py) install_requires from pyusb>=1.0.0b1 to pyusb>=1.0.0 to use the last PyUSB release.

@todbot
Copy link
Owner

todbot commented Jan 26, 2017

Hi @jnth,
The version on PyPi is a fork of this repo, maintained by @salimfadhley.

@pedronavf
Copy link
Contributor Author

@todbot, according to #219 you can push to PyPi, can't you? I'm working on a Home Assistant plugin and I need a working package in PyPi for people to use it.

@salimfadhley
Copy link
Contributor

salimfadhley commented Jan 26, 2017 via email

@todbot
Copy link
Owner

todbot commented Jan 26, 2017

Hey @salimfadhley, what if we made an entirely new github repo that's just for the blink1 Python package (you can own it if you want), but that we're both contributors on?

I initially made this repo not long after coming from SVN and hadn't yet embraced the "many small repo" philosophy. Now I quite like it and I'm finding myself frustrated having so much different functionality all in one big "blink1" repo.

@salimfadhley
Copy link
Contributor

I probably shouldn't be the owner but I'd be happy to be a contributor. I've been meaning to contribute a few things. We still use Blink1s at Bank of America for all sorts of build-related notifications. Putting Python in it's own repo is a very good idea - it makes it so much easier for people who just want Python.

Speaking of this - probably the most valuable thing I can contribute is to set up the CI and get it building automatically. Let me know if that helps you.

Sal

@pedronavf
Copy link
Contributor Author

pedronavf commented Jan 26, 2017 via email

@todbot
Copy link
Owner

todbot commented Jan 26, 2017

Agreed, @pedronavf. It's on my todo list to move all thingm-related repos to the ThingM org.

@todbot
Copy link
Owner

todbot commented Jan 26, 2017

Hi @salimfadhley,
Yes, I would very much like assistant in setting up the PyPi publishing and CI (I just got Travis & Appveyor sorta working for some other multi-OS projects I maintain and it's wonderful)

I set up the current todbot/blink1/python directory as a new repo (with all the history) here:
https://github.com/todbot/blink1-python
You've been added as a collaborator. I haven't added a LICENSE yet as I figure you should have the most say in that.

todbot added a commit that referenced this pull request Jan 17, 2018
Fixed "The device does not support the specified langid" error
todbot added a commit that referenced this pull request Jan 17, 2018
Fixed "The device does not support the specified langid" error
todbot added a commit that referenced this pull request Jan 17, 2018
Fixed "The device does not support the specified langid" error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants