Skip to content

Conversation

toddbluhm
Copy link
Owner

Based on some user feedback common sense, the -r and -f flags are mutually exclused (can't be used at the same time), however they serve the same purpose, providing a custom file path.

Simply our flags by only using the -f flag to provide a custom path.

Now, if you provide a -e flag, the -f flag will assume you are pointing to a custom .rc file location.

Likewise if you use just -f it will assume you are pointing to a custom .env file path.

Resolves #359 and #372

@toddbluhm toddbluhm requested a review from k-yle July 3, 2025 06:31
@k-yle k-yle linked an issue Jul 3, 2025 that may be closed by this pull request
Copy link
Collaborator

@k-yle k-yle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, it'll be nice to simplify this. But I wonder if we should show a warning if somone upgrades to v11 and tries to use the -r flag, to make migration easier?

And I think we'll also need to update the README to remove -r

@toddbluhm
Copy link
Owner Author

That is a great idea to show the warning!

And great catch on updating the README, thought I had already done that.

@toddbluhm toddbluhm force-pushed the feat-combine-f-r-flags branch from 01396b6 to abf4cca Compare July 12, 2025 09:23
@toddbluhm toddbluhm requested a review from k-yle July 12, 2025 09:25
@toddbluhm toddbluhm merged commit 660f3e0 into master Jul 17, 2025
22 checks passed
@toddbluhm toddbluhm deleted the feat-combine-f-r-flags branch July 17, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

environments and file options may be mutually exclusive Using -f is not using a local file, throwing error.
2 participants