Skip to content

Commit e822bbd

Browse files
committed
fix(core): deleted doc should not appear in tag pages (#8143)
close AF-1206
1 parent 7fe8d7e commit e822bbd

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

packages/frontend/core/src/components/page-list/tags/tag-list-item.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import * as styles from './tag-list-item.css';
1313

1414
const TagListTitleCell = ({
1515
title,
16-
pageCount,
1716
}: Pick<TagListItemProps, 'title' | 'pageCount'>) => {
1817
const t = useI18n();
1918
return (
@@ -24,12 +23,13 @@ const TagListTitleCell = ({
2423
>
2524
{title || t['Untitled']()}
2625
</div>
26+
{/* //TODO(@EYHN): when indexer is ready, add this back
2727
<div
2828
data-testid="page-list-item-preview-text"
2929
className={styles.titleCellPreview}
3030
>
3131
{` · ${t['com.affine.tags.count']({ count: pageCount || 0 })}`}
32-
</div>
32+
</div> */}
3333
</div>
3434
);
3535
};

packages/frontend/core/src/pages/workspace/tag/index.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,9 @@ export const TagDetail = ({ tagId }: { tagId?: string }) => {
3737

3838
const filteredPageMetas = useMemo(() => {
3939
const pageIdsSet = new Set(pageIds);
40-
return pageMetas.filter(page => pageIdsSet.has(page.id));
40+
return pageMetas
41+
.filter(page => pageIdsSet.has(page.id))
42+
.filter(page => !page.trash);
4143
}, [pageIds, pageMetas]);
4244

4345
const isActiveView = useIsActiveView();

0 commit comments

Comments
 (0)