Fix cluster_application_kill method #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recently introduced cluster_application_kill() method was erroneously calling `self.put()` to issue the status change to `KILLED`. This resulted in an AttributeError exception: ``` ''ResourceManager' object has no attribute 'put'' ``` in client code. The base class issues put calls, via its `update()` method. Once updated, application kill requests succeed.
lresende
approved these changes
Oct 30, 2018
Collaborator
lresende
left a comment
lresende
left a comment
There was a problem hiding this comment.
Thanks for catching this. LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently introduced cluster_application_kill() method was erroneously
calling
self.put()to issue the status change toKILLED. This resultedin an AttributeError exception:
in client code.
The base class issues put calls, via its
update()method. Once updated,application kill requests succeed.