Skip to content

Conversation

CachingFoX
Copy link
Contributor

A bug fix for issue #144

The while loop will be stopped if there no table rows elements in loaded results

@CachingFoX
Copy link
Contributor Author

I check the Travis CI reports: builds for Python 3.5 and 3.7 run fine, but with Python 3.6 the build raise an exception. I don't understand why?

@FriedrichFroebel
Copy link
Collaborator

Wouldn't be if not geocaches_table.find_all("tr")) enough? And we might should save geocaches_table.find_all("tr") in an own variable before and use it in line 254 as well to reduce duplicate code.

@CachingFoX
Copy link
Contributor Author

Wouldn't be if not geocaches_table.find_all("tr")) enough?
Yes it could! I changed this.
And we might should save geocaches_table.find_all("tr") in an own variable before and use it in line 254 as well to reduce duplicate code.
I did it :-) and push the update to Github.

Please can you check my PR, again?

Copy link
Collaborator

@FriedrichFroebel FriedrichFroebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am not sure about the failing test case though, but it seems to switch between the different versions and is not really related to this change.

@FriedrichFroebel
Copy link
Collaborator

I added a new issue for the failing test as it seems to be unrelated to this PR, so this is ready to be merged.

@FriedrichFroebel FriedrichFroebel merged commit de9b48e into tomasbedrich:master May 3, 2020
@CachingFoX CachingFoX deleted the issue-144-stop-search branch May 3, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants