Skip to content

Issue 144 stop search #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 3, 2020
Merged

Issue 144 stop search #145

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ec4e554
fix bug from issue #144 - stop generator if there no more results
Apr 23, 2020
13b8d25
#144 a little improvement of the bugfix
Apr 30, 2020
7ef2b19
store results of find_all("tr") in a local variable - simplify breaki…
May 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions pycaching/geocaching.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,10 @@ def search(self, point, limit=float("inf")):
while True:
# get one page
geocaches_table, whole_page = self._search_get_page(point, start_index)
rows = geocaches_table.find_all("tr")

if not geocaches_table:
# result is empty - no more caches
# leave loop if there are no (more) results
if not rows:
return

# prepare language-dependent mappings
Expand All @@ -251,7 +252,7 @@ def search(self, point, limit=float("inf")):
}

# parse caches in result
for start_index, row in enumerate(geocaches_table.find_all("tr"), start_index):
for start_index, row in enumerate(rows, start_index):

limit -= 1 # handle limit
if limit < 0:
Expand Down