AS#131482348128949, Refactor Mailchimp API wrapper to be generic user preferences service

-- Adapted calling code for express based preference API

Author: vikasrohit

app/services/userPreferences.service.js

@@ -20,7 +20,7 @@ import angular from 'angular'
         mailchimpApi.one('users', user.userId)
         .one('preferences', 'email').get()
         .then(function(resp) {
-          resolve(resp)
+          resolve(resp.subscriptions)
         })
         .catch(function(err) {
           if (err.status === 404) {
@@ -42,21 +42,20 @@ import angular from 'angular'
 
     function saveEmailPreferences(user, preferences) {
       var settings = {
-        userId: user.userId,
         firstName: user.firstName,
         lastName: user.lastName,
         subscriptions: {}
       }
       if (!preferences) {
-        settings.subscriptions[CONSTANTS.MAILCHIMP_NL_GEN] = true
+        settings.subscriptions['TOPCODER_NL_GEN'] = true
       } else {
         settings.subscriptions = preferences
       }
       return $q(function(resolve, reject) {
         mailchimpApi.one('users', user.userId)
-        .customPUT(settings, 'preferences/email')
+        .customPUT({ param: settings }, 'preferences/email')
         .then(function(resp) {
-          resolve(resp)
+          resolve(resp.subscriptions)
         })
         .catch(function(err) {
           logger.error('Error adding member to subscription list', err)

app/settings/email/email.controller.js

@@ -68,24 +68,30 @@ import angular from 'angular'
         if (!subscription) {
           // add member to the list with default preferences
           UserPreferencesService.saveEmailPreferences(userData).then(function(resp) {
-            logger.debug(resp)
+            logger.debug(JSON.stringify(resp))
+            validateState(resp)
+
           }).catch(function(err) {
             // no error to user
             //TODO some error alert to community admin
             logger.debug('error in adding user to member list')    
           })
         } else {
           if (subscription) {
-            vm.newsletters.forEach(function(newsletter) {
-              if (subscription[newsletter.id]) {
-                newsletter.enabled = true
-              }
-            })
+            validateState(subscription)
           }
         }
       })
     }
 
+    function validateState(subscription) {
+      vm.newsletters.forEach(function(newsletter) {
+        if (subscription[newsletter.id]) {
+          newsletter.enabled = true
+        }
+      })
+    }
+
     function isDirty() {
       var dirty = false
       vm.newsletters.forEach(function(newsletter) {