Merge pull request #39 from afrisalyp/issue-272-1

Handle broken user assignment. Handle get tc username with no criteria.

Author: jmgasper

services/IssueService.js

@@ -658,6 +658,11 @@ async function handleIssueUnAssignment(event, issue) {
 
     if (dbIssue.assignee) {
       const assigneeUserId = gitHelper.getUserIdByLogin(event, dbIssue.assignee);
+      if (!assigneeUserId) {
+        // The assignement of this user was failed and broken.
+        // We don't need to handle the unassignment.
+        return;
+      }
       logger.debug(`Looking up TC handle of git user: ${assigneeUserId}`);
       const userMapping = await userService.getTCUserName(event.provider, assigneeUserId);
 

services/UserService.js

@@ -39,6 +39,9 @@ async function getTCUserName(provider, gitUser) {
       criteria.gitlabUsername = gitUser;
     }
   }
+  if (_.isEmpty(criteria)) {
+    throw new Error('Can\'t find the TCUserName. Invalid gitUser.');
+  }
   return await dbHelper.scanOne(models.UserMapping, criteria);
 }