#12 - Fix issue where invalid model attributes did not raise validation errors

Author: callmekatootie

app.js

@@ -2,7 +2,8 @@
  * The application entry point
  */
 
-require('./src/bootstrap')
+// Commenting out since logger wrapper is now set in elasticsearch wrapper
+// require('./src/bootstrap')
 const config = require('config')
 const express = require('express')
 const cross = require('cors')

src/bootstrap.js

@@ -21,7 +21,7 @@ function buildServices (dir) {
       let serviceName = curPath.split('modules')[1]
       serviceName = serviceName.substr(1, serviceName.length - 4)
       logger.info(`add decorates for service --> ${serviceName}`)
-        logger.buildService(serviceName, require(curPath)); // eslint-disable-line
+      logger.buildService(serviceName, require(curPath)) // eslint-disable-line
     }
   })
 }

src/common/es-helper.js

@@ -1145,6 +1145,8 @@ function wrapElasticSearchOp (methods, Model) {
   // methods: create, search, patch, get, remove
   const resource = getResource(Model.name)
 
+  logger.buildService(Model.name, methods)
+
   return _.mapValues(methods, func => {
     if (func.name === 'search') {
       return async (...args) => {

src/modules/user/service.js

@@ -7,8 +7,16 @@ const models = require('../../models/index')
 const helper = require('../../common/helper')
 const methods = helper.getServiceMethods(
   models.User,
-  { handle: joi.string().required() },
-  { handle: joi.string() },
+  {
+    handle: joi.string().required(),
+    firstName: joi.string().required(),
+    lastName: joi.string().required()
+  },
+  {
+    handle: joi.string(),
+    firstName: joi.string(),
+    lastName: joi.string()
+  },
   { handle: joi.string(), roleId: joi.string() },
   async query => {
     let prefix = 'select * from DUser'