Merge pull request #407 from topcoder-platform/issues-389

Issues-389: show 'Home' in the breadcrumbs

Author: jmgasper

vanilla/applications/vanilla/controllers/class.draftscontroller.php

@@ -32,6 +32,7 @@ public function index($offset = '0') {
         $this->addJsFile('jquery.gardenmorepager.js');
         $this->addJsFile('discussions.js');
         $this->title(t('My Drafts'));
+        $this->setData('Breadcrumbs', [['Name' => t('My Drafts'), 'Url' => '/drafts']]);
 
         // Validate $Offset
         if (!is_numeric($offset) || $offset < 0) {

vanilla/library/SmartyPlugins/function.breadcrumbs.php

@@ -23,6 +23,5 @@ function smarty_function_breadcrumbs($params, &$smarty) {
 
     $options = arrayTranslate($params, ['homeurl' => 'HomeUrl', 'hidelast' => 'HideLast']);
 
-    // Don't show a home link by default
-    return Gdn_Theme::breadcrumbs($breadcrumbs, val('homelink', $params, false), $options);
+    return Gdn_Theme::breadcrumbs($breadcrumbs, val('homelink', $params, true), $options);
 }

vanilla/library/core/class.theme.php

@@ -57,7 +57,7 @@ public static function assetEnd() {
      * @param array $options
      * @return string
      */
-    public static function breadcrumbs($data, $homeLink = false, $options = []) {
+    public static function breadcrumbs($data, $homeLink = true, $options = []) {
         $format = '<a href="{Url,html}" itemprop="url"><span itemprop="title">{Name,html}</span></a>';
 
         $result = '';
@@ -87,11 +87,6 @@ public static function breadcrumbs($data, $homeLink = false, $options = []) {
 
         $defaultRoute = ltrim(val('Destination', Gdn::router()->getRoute('DefaultController'), ''), '/');
 
-        // FIX: Don't show current page
-        if(count($data) <= 1) {
-                return '';
-        }
-
         $count = 0;
         $dataCount = 0;
         $homeLinkFound = false;