Skip to content

Commit 0cc797a

Browse files
Merge pull request #382 from topcoder-platform/TCA-584_alt-social
TCA-584 Minor Cleanup of Cert view -> TCA-516_optimize-certificate-sharing
2 parents a7a0dfd + d62a8ea commit 0cc797a

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
export { default as CertificateView } from './CertificateView'
2+
export type { CertificateViewStyle } from './CertificateView'

src-ts/tools/learn/course-certificate/user-certificate/UserCertificate.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import {
66
profileGetAsync,
77
UserProfile
88
} from '../../../../lib'
9-
import CertificateView, { CertificateViewStyle } from '../certificate-view/CertificateView'
9+
import { getViewStyleParamKey } from '../../learn.routes'
10+
import { CertificateView, CertificateViewStyle } from '../certificate-view'
1011

1112
import styles from './UserCertificate.module.scss'
1213

@@ -61,7 +62,7 @@ const UserCertificate: FC<{}> = () => {
6162
provider={providerParam}
6263
onCertificationNotCompleted={() => { }}
6364
hideActions
64-
viewStyle={queryParams.get('view-style') as CertificateViewStyle}
65+
viewStyle={queryParams.get(getViewStyleParamKey()) as CertificateViewStyle}
6566
/>
6667
</div>
6768
)}

src-ts/tools/learn/learn-config/learn.default.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import { LearnConfigModel } from './learn-config.model'
33
export const LearnConfigDefault: LearnConfigModel = {
44
API: 'http://localhost:3001/v5/learning-paths',
55
CERT_ALT_PARAMS: {
6-
'view-port': 'large-container',
6+
'view-style': 'large-container',
77
},
88
CERT_DOMAIN: 'https://certificate.topcoder-dev.com',
99
CERT_ELEMENT_SELECTOR: {

src-ts/tools/learn/learn.routes.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,10 @@ export function getUserCertificateUrl(provider: string, certification: string, h
6666
return `${window.location.origin}${getCoursePath(provider, certification)}/${handle}${LEARN_PATHS.certificate}`
6767
}
6868

69+
export function getViewStyleParamKey(): string {
70+
return Object.keys(LearnConfig.CERT_ALT_PARAMS)[0]
71+
}
72+
6973
export const rootRoute: string = LEARN_PATHS.root
7074
export const absoluteRootRoute: string = `${window.location.origin}${LEARN_PATHS.root}`
7175

0 commit comments

Comments
 (0)