Skip to content

Commit 1468545

Browse files
authored
Merge pull request #294 from topcoder-platform/TCA-440_certificate-progress
TCA-440: call certification completion based on assessment completion
2 parents 3099419 + 0ea5539 commit 1468545

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

src-ts/tools/learn/free-code-camp/FreeCodeCamp.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ const FreeCodeCamp: FC<{}> = () => {
259259
useEffect(() => {
260260
if (
261261
certificateProgress &&
262-
certificateProgress.courseProgressPercentage === 100 &&
262+
certificateProgress.certificationProgressPercentage === 100 &&
263263
certificateProgress.status === UserCertificationProgressStatus.inProgress
264264
) {
265265
userCertificationProgressUpdateAsync(

src-ts/tools/learn/learn-lib/course-outline/CourseOutline.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ const CourseOutline: FC<CourseOutlineProps> = (props: CourseOutlineProps) => {
5454
shortDescription={module.meta.introCopy}
5555
title={module.meta.name}
5656
onItemClick={props.onItemNavigate}
57+
isAssessment={module.meta.isAssessment}
5758
/>
5859
))}
5960
</div>

src-ts/tools/learn/learn-lib/course-outline/collapsible-item/CollapsibleItem.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ interface CollapsibleListItem {
1717
interface CollapsibleItemProps {
1818
active?: string
1919
duration: LearnModule['meta']['estimatedCompletionTime']
20+
isAssessment: boolean
2021
itemId?: (item: any) => string
2122
items: Array<CollapsibleListItem>
2223
lessonsCount: number
@@ -31,8 +32,6 @@ interface CollapsibleItemProps {
3132
const CollapsibleItem: FC<CollapsibleItemProps> = (props: CollapsibleItemProps) => {
3233
const [isOpen, setIsOpen]: [boolean, Dispatch<SetStateAction<boolean>>] = useState<boolean>(false)
3334

34-
const isAssessment: boolean = props.lessonsCount === 1
35-
3635
const toggle: () => void = useCallback(() => {
3736
setIsOpen(open => !open)
3837
}, [])
@@ -89,7 +88,7 @@ const CollapsibleItem: FC<CollapsibleItemProps> = (props: CollapsibleItemProps)
8988
<div className={styles['title-row']} onClick={toggle}>
9089
<StatusIcon completed={isCompleted} partial={isPartial} />
9190
<span className={styles['title']}>
92-
{isAssessment && (
91+
{props.isAssessment && (
9392
<div className={classNames(styles['title-tag'], 'label')}>
9493
assessment
9594
</div>

src-ts/tools/learn/learn-lib/lesson-provider/learn-module-meta.model.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@ export interface LearnModuleMeta {
55
value: number
66
}
77
introCopy: Array<string>
8-
lessonCount: number
8+
isAssessment: boolean
99
name: string
1010
}

src-ts/tools/learn/learn-lib/user-certifications-provider/user-certifications-functions/learn-user-certification-progress.model.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@ export interface LearnUserCertificationProgress extends LearnModelBase {
77
academicHonestyPolicyAcceptedAt?: number,
88
certification: string
99
certificationId: string
10+
certificationProgressPercentage: number
11+
certType: 'certification'
1012
completedDate?: string
1113
courseId: string
1214
courseKey: string

0 commit comments

Comments
 (0)