Skip to content

Commit 1be3f52

Browse files
authored
Merge pull request #321 from topcoder-platform/feat/GAME-82
QA fixes badge create page GAME-82
2 parents 5b5eef6 + 0b761d5 commit 1be3f52

File tree

4 files changed

+19
-6
lines changed

4 files changed

+19
-6
lines changed

src-ts/lib/form/Form.tsx

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ interface FormProps<ValueType, RequestType> {
3535
readonly onChange?: (inputs: ReadonlyArray<FormInputModel>) => void,
3636
readonly onSuccess?: () => void
3737
readonly requestGenerator: (inputs: ReadonlyArray<FormInputModel>) => RequestType
38+
readonly resetFormAfterSave?: boolean
3839
readonly resetFormOnUnmount?: boolean
3940
readonly save: (value: RequestType) => Promise<void>
4041
}
@@ -120,16 +121,21 @@ const Form: <ValueType extends any, RequestType extends any>(props: FormProps<Va
120121
setFormDef({ ...formDef })
121122
setInputs(formGetInputFields(formDef.groups || []))
122123
setFormKey(Date.now())
124+
setFormError(undefined)
123125
}
124126

125127
async function onSubmitAsync(event: FormEvent<HTMLFormElement>): Promise<void> {
126128
const values: RequestType = props.requestGenerator(inputs)
127129
formOnSubmitAsync<RequestType>(props.action || 'submit', event, formDef, values, props.save, props.onSuccess)
128130
.then(() => {
129-
setFormKey(Date.now())
130-
formOnReset(inputs, props.formValues)
131-
setFormDef({ ...formDef })
132-
setInputs(formGetInputFields(formDef.groups || []))
131+
if (!props.resetFormAfterSave) {
132+
setFormKey(Date.now())
133+
formOnReset(inputs, props.formValues)
134+
setFormDef({ ...formDef })
135+
setInputs(formGetInputFields(formDef.groups || []))
136+
} else {
137+
onReset()
138+
}
133139
})
134140
.catch((error: string | undefined) => {
135141
setFormError(error)

src-ts/lib/form/form-groups/form-input/input-textarea/InputTextarea.module.scss

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,4 +12,10 @@
1212
margin-left: calc(-1 * $border);
1313
overflow: hidden;
1414
padding: $border;
15-
}
15+
16+
&::placeholder {
17+
color: $black-60;
18+
opacity: 1;
19+
text-transform: none;
20+
}
21+
}

src-ts/tools/gamification-admin/game-lib/modals/badge-created-modal/BadgeCreatedModal.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ const BadgeCreatedModal: FC<BadgeCreatedModalProps> = (props: BadgeCreatedModalP
4949
<Button
5050
label='Create a new badge'
5151
buttonStyle='secondary'
52-
onClick={() => window.location.reload()}
52+
onClick={onClose}
5353
/>
5454
</div>
5555
</div>

src-ts/tools/gamification-admin/pages/create-badge/create-badge-form/CreateBadgeForm.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ const CreateBadgeForm: FC<CreateBadgeFormProps> = (props: CreateBadgeFormProps)
4242
<Form
4343
formDef={props.formDef}
4444
requestGenerator={generateRequest}
45+
resetFormAfterSave={true}
4546
resetFormOnUnmount={true}
4647
save={saveAsync}
4748
/>

0 commit comments

Comments
 (0)