PR feedback

Author: vas3a

src-ts/tools/learn/learn-lib/functions/learn.factory.ts

@@ -9,15 +9,15 @@ export interface LearnResponseModel {
 export function create<T extends LearnResponseModel>(item: T): T {
 
     if (typeof item?.createdAt === 'string') {
-        set(item, 'createdAt', new Date(item.createdAt))
+        item.createdAt = new Date(item.createdAt)
     }
 
     if (typeof item?.updatedAt === 'string') {
-        set(item, 'updatedAt', new Date(item.updatedAt))
+        item.updatedAt = new Date(item.updatedAt)
     }
 
     if (typeof item?.publishedAt === 'string') {
-        set(item, 'publishedAt', new Date(item.publishedAt))
+        item.publishedAt = new Date(item.publishedAt)
     }
 
     return item

src-ts/tools/learn/welcome/progress-block/progress-action/ProgressAction.tsx

@@ -43,7 +43,7 @@ const ProgressAction: FC<ProgressActionProps> = (props: ProgressActionProps) =>
     const certificationsById: { [key: string]: LearnCertification } = useMemo(() => (
         props.allCertifications
             .reduce((certifs, certificate) => {
-                set(certifs, [certificate.id], certificate)
+                certifs[certificate.id] = certificate
                 return certifs
             }, {} as unknown as { [key: string]: LearnCertification })
     ), [props.allCertifications])

src-ts/utils/settings/account/Account.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable jsx-a11y/tabindex-no-positive */
 import { Dispatch, FC, SetStateAction, useCallback, useContext, useState } from 'react'
 import Modal from 'react-responsive-modal'
 
@@ -70,7 +71,7 @@ const Account: FC<{}> = () => {
                 <Button
                     label='edit name'
                     onClick={toggleEditName}
-                    tabIndex={-1}
+                    tabIndex={1}
                     buttonStyle='secondary'
                 />
             </Card>
@@ -93,7 +94,7 @@ const Account: FC<{}> = () => {
                 <Button
                     label='change password'
                     onClick={toggleChangePassword}
-                    tabIndex={-1}
+                    tabIndex={2}
                     buttonStyle='secondary'
                 />
             </Card>