Merge pull request #761 from topcoder-platform/env-fixes

fix env types conversion -> dev

Author: vas3a

src/config/environments/react-env.ts

@@ -3,25 +3,28 @@
 
 export function getReactEnv<T>(varName: string, defaultValue?: string | boolean | number): T {
     const hasDefaultValue: boolean = arguments.length > 1
+
     let value = process.env[`REACT_APP_${varName}`] as unknown as T
 
     if (value === undefined && !hasDefaultValue) {
         throw new Error(`${varName} is not defined in process.env!`)
     }
 
-    // convert to boolean
-    if (value === 'false' || value === 'true') {
-        value = (value === 'true' as unknown) as T
+    // convert to number
+    if (!Number.isNaN(Number(value))) {
+        value = Number(value as unknown) as T
     }
 
     // convert to null
     if (value === 'null') {
         value = (null as unknown) as T
+        // return early as the bottom expresion will just return the "default value"
+        return value
     }
 
-    // convert to number
-    if (!Number.isNaN(Number(value))) {
-        value = (null as unknown) as T
+    // convert to boolean
+    if (value === 'false' || value === 'true') {
+        value = (value === 'true' as unknown) as T
     }
 
     return (value ?? defaultValue) as T