Skip to content

Commit cb442d0

Browse files
authored
Merge pull request #722 from topcoder-platform/MP-178_fix-modals-scroll
MP-178 BaseModal: do not use bodyscrolllock
2 parents 251b35c + 3821b45 commit cb442d0

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/libs/ui/lib/components/modals/base-modal/BaseModal.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const BaseModal: FC<BaseModalProps> = (props: BaseModalProps) => {
4040
}
4141

4242
useEffect(() => {
43-
if (props.blockScroll === false) {
43+
if (!props.blockScroll) {
4444
document.documentElement.style.overflow = props.open ? 'hidden' : ''
4545
document.body.style.overflow = props.open ? 'hidden' : ''
4646
}
@@ -58,6 +58,8 @@ const BaseModal: FC<BaseModalProps> = (props: BaseModalProps) => {
5858
),
5959
}}
6060
closeIcon={<IconOutline.XIcon className={styles['close-icon']} width={24} height={24} />}
61+
// send blockScroll as false unless we get a specific true from props
62+
blockScroll={props.blockScroll === true}
6163
>
6264
{props.title && (
6365
<>

0 commit comments

Comments
 (0)