clean up perPage in Joi

Author: ThomasKranitsas

app-bootstrap.js

@@ -9,4 +9,4 @@ const Joi = require('joi')
 Joi.optionalId = () => Joi.string().uuid()
 Joi.id = () => Joi.optionalId().required()
 Joi.page = () => Joi.number().integer().min(1).default(1)
-Joi.perPage = () => Joi.number().integer().min(1).max(10001).default(config.DEFAULT_PAGE_SIZE)
+Joi.perPage = () => Joi.number().integer().min(1).max(10000).default(config.DEFAULT_PAGE_SIZE)

config/default.js

@@ -6,7 +6,7 @@ module.exports = {
   LOG_LEVEL: process.env.LOG_LEVEL || 'debug',
   PORT: process.env.PORT || 3000,
   API_VERSION: process.env.API_VERSION || 'v5',
-  DEFAULT_PAGE_SIZE: process.env.DEFAULT_PAGE_SIZE || 1000,
+  DEFAULT_PAGE_SIZE: process.env.DEFAULT_PAGE_SIZE || 50,
   // used to properly set the header response to api calls for services behind a load balancer
   API_BASE_URL: process.env.API_BASE_URL || `http://localhost:3000`,
 

src/services/ResourceService.js

@@ -179,7 +179,7 @@ getResources.schema = {
   challengeId: Joi.id(),
   roleId: Joi.optionalId(),
   page: Joi.page().default(1),
-  perPage: Joi.perPage().default(50),
+  perPage: Joi.perPage(),
   // sortBy: Joi.string().valid('memberHandle', 'created').default('created'), // have to reindex to sort by memberHandle
   sortBy: Joi.string().valid('created').default('created'),
   sortOrder: Joi.string().valid('desc', 'asc').default('asc')
@@ -498,7 +498,7 @@ listChallengesByMember.schema = {
   criteria: Joi.object().keys({
     resourceRoleId: Joi.string().uuid(),
     page: Joi.page().default(1),
-    perPage: Joi.perPage().default(50)
+    perPage: Joi.perPage()
   }).required()
 }