Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common part from hironx #7

Closed
3 tasks done
k-okada opened this issue Nov 9, 2013 · 1 comment
Closed
3 tasks done

Extract common part from hironx #7

k-okada opened this issue Nov 9, 2013 · 1 comment
Assignees
@130s

Comments

@k-okada
Copy link
Member

k-okada commented Nov 9, 2013

ここからの移譲．

hironxとコードが被らないようにしたいです．

また，
#2 , #3 などの一部は

http://rtm-ros-robotics.googlecode.com/svn/trunk/rtmros_hironx/hironx_ros_bridge/test/
でトライされています．

nextage_description,
hironx_description
さえあれば，あとは共通のコード（特にCMake周りか？）で動くようになっている，というのがベストでしょうか．

また，一部にhironxとnextageで微妙にファイル名が違うのも揃えておきたい所ではあります．

  • script/nextage_client_standalone.py vs script/hironx.py,
  • src/nextage_client.py vs src/hironx.py,
  • moveit_planning_exec.launch vs moveit_planning_execution.launch
@ghost ghost assigned 130s Nov 9, 2013
@130s 130s mentioned this issue Nov 14, 2013
Closed
130s pushed a commit that referenced this issue Nov 14, 2013
nextage_ros_bridge) rename script (due to discussion in issue #7)
5c94c35
130s referenced this issue in 130s/rtmros_nextage Nov 14, 2013
nextage_ros_bridge) rename script (due to discussion in issue #7)
bf40e62 
nextage_ros_bridge) Delete renamed file in previous commit (for some reason this change didn't get commited)
130s pushed a commit that referenced this issue Nov 14, 2013
nextage_ros_bridge) rename script (due to discussion in issue #7)
344c886 
nextage_ros_bridge) Delete renamed file in previous commit (for some reason this change didn't get commited)
@130s 130s mentioned this issue Nov 29, 2013
Closed
@130s
Copy link
Contributor

130s commented Dec 28, 2013

Moved to http://code.google.com/p/rtm-ros-robotics/issues/detail?id=291

@130s 130s closed this as completed Dec 28, 2013
@k-okada k-okada mentioned this issue Feb 8, 2014
Closed
k-okada pushed a commit to start-jsk/rtmros_hironx that referenced this issue Feb 8, 2014
hironx_ros_bridge) use the same filenames with other rtmros_common ch…
e51b4f4 
…ildren (ie. nextage_ros_bridge for now. Partial fix to tork-a/rtmros_nextage#7)
130s added a commit that referenced this issue Jan 27, 2016
@130s
Merge pull request #7 from k-okada/gz
bc82ba5 
fix Gz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@130s 130s

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@k-okada @130s