-
Notifications
You must be signed in to change notification settings - Fork 46
fix(sdk): upgrade @google-cloud/opentelemetry-cloud-trace-exporter
#819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
WalkthroughThe pull request bumps the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 12683a1 in 34 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/package.json:58
- Draft comment:
Major version bump for @google-cloud/opentelemetry-cloud-trace-exporter. Verify that breaking changes are addressed in your integration. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically a major version bump. The comment asks the PR author to verify that breaking changes are addressed, which falls under the rule of not asking the author to ensure behavior is intended or to double-check things. Therefore, this comment should be removed.
Workflow ID: wflow_IldRkfQquJyR4tIw
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
@nirga Sorry for bothering you, but can you review the change? |
|
Sorry @yu-iskw merging |
@google-cloud/opentelemetry-cloud-trace-exporter@google-cloud/opentelemetry-cloud-trace-exporter
|
@nirga Thank you so much for quickly merging. I appreciate if you could release a new version. |
|
Done @yu-iskw |
|
Many thanks! |
follows up #814
It is outdated. I should have made sure of that.
https://www.npmjs.com/package/@google-cloud/opentelemetry-cloud-trace-exporter
Important
Upgrade
@google-cloud/opentelemetry-cloud-trace-exporterto^3.0.0inpackage.json.@google-cloud/opentelemetry-cloud-trace-exporterfrom^1.0.0to^3.0.0inpackage.json.This description was created by
for 12683a1. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit