New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make gas calculation faithfulness configurable #1279

Merged
merged 49 commits into from Jan 7, 2019

Conversation

Projects
None yet
3 participants
@feliam
Copy link
Contributor

feliam commented Nov 23, 2018

  • split extra gas calculation to its own method
  • add config constant for choosing gas faithfulness type (faithful => slow)

This change is Reviewable

@feliam feliam changed the title [WIP] Make gas calculation faithfulness configurable Make gas calculation faithfulness configurable Dec 11, 2018

feliam added some commits Dec 11, 2018

CC
CC
Show resolved Hide resolved manticore/platforms/evm.py Outdated
@feliam

This comment has been minimized.

Copy link
Contributor

feliam commented Jan 5, 2019

One additional feature request here: can we add a gas display to https://github.com/trailofbits/manticore/blob/master/manticore/platforms/evm.py#L1651-L1728 so e.g. the VerboseTrace plugin will show it?

We should probably also display the gas cost of given executed instructions. But this can be done in another PR.

Already done it here. ✔️

Show resolved Hide resolved manticore/platforms/evm.py Outdated
@@ -608,6 +644,16 @@ def __setstate__(self, state):
super().__setstate__(state)

def _get_memfee(self, address, size=1):
"""
This calculates the ammount of extra gas needed for accessing to

This comment has been minimized.

@disconnect3d

disconnect3d Jan 7, 2019

Contributor
Suggested change Beta
This calculates the ammount of extra gas needed for accessing to
This calculates the amount of extra gas needed for accessing to

Also, can we remove the additional indent made here?

Show resolved Hide resolved manticore/platforms/evm.py Outdated
Show resolved Hide resolved manticore/platforms/evm.py Outdated

feliam and others added some commits Jan 7, 2019

Update manticore/platforms/evm.py
Co-Authored-By: feliam <felipe.andres.manzano@gmail.com>

@disconnect3d disconnect3d merged commit c9eb624 into master Jan 7, 2019

5 checks passed

codeclimate All good!
Details
codeclimate/total-coverage 71% (0.1% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@disconnect3d disconnect3d deleted the dev-config-gas branch Jan 7, 2019

disconnect3d added a commit that referenced this pull request Jan 8, 2019

Merge branch 'master' into refactor-events
* master:
  Make gas calculation faithfulness configurable (#1279)
  Fix terminated states resurrection (#1326)
  Make is_human a property (#1323)
  added warning and error to sys_arch_prctl (#1319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment