New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make is_human a property #1323

merged 3 commits into from Jan 7, 2019


None yet
1 participant
Copy link

disconnect3d commented Jan 4, 2019

This PR changes the Transaction.is_human method to a property and adds a docstring that explains what we understand as a "human transaction" along with an example.

The motivation for this change is that we had two places in the codebase where we used it as if it would be a property while it wasn't. This code is probably bugged - probably as I hadn't confirmed it with an example but certainly making if tx.is_human: would always be true:

if self._depth == 'human' and not tx.is_human:
if self._depth == 'internal' and tx.is_human:

This change is Reviewable

Show resolved Hide resolved manticore/platforms/ Outdated

disconnect3d added some commits Jan 4, 2019

@disconnect3d disconnect3d requested review from mossberg and feliam and removed request for mossberg Jan 4, 2019

@disconnect3d disconnect3d merged commit f349adb into master Jan 7, 2019

5 checks passed

codeclimate All good!
codeclimate/total-coverage 70% (0.0% change)
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
license/cla Contributor License Agreement is signed.

@disconnect3d disconnect3d deleted the fix-is-human branch Jan 7, 2019

disconnect3d added a commit that referenced this pull request Jan 8, 2019

Merge branch 'master' into refactor-events
* master:
  Make gas calculation faithfulness configurable (#1279)
  Fix terminated states resurrection (#1326)
  Make is_human a property (#1323)
  added warning and error to sys_arch_prctl (#1319)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment