New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor state/platform refactor #1320

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
2 participants
@disconnect3d
Copy link
Contributor

disconnect3d commented Jan 2, 2019

The StateBase class had two properties that are only used in native engines: cpu and mem.

Those two used self._platform.current and that current is a property in linux and decree platforms that returns current process platfrom (?).

The PR also removes unused/redundant code in StateBase: _init_context and record_branch methods.


This change is Reviewable

Minor state/platform refactor
The `StateBase` class had two properties that are only used in native
engines: `cpu` and `mem`.

Those two used `self._platform.current` and that `current` is a
property in linux and decree platforms that returns current process
platfrom (?).
@yan

yan approved these changes Jan 2, 2019

@disconnect3d disconnect3d merged commit 23199f2 into master Jan 2, 2019

5 checks passed

codeclimate All good!
Details
codeclimate/total-coverage 70% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@disconnect3d disconnect3d deleted the minor-refactor branch Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment