- #149
Comments
|
i just tried compiling latest master(50e64f0) with LTO, which seems to compile and run just fine. also i dont know if the owner of this package is the same one publishing the AUR; also please be more specific which AUR package you use (there is |
i have not tried the aur package, i had tried the latest git and compiled with cargo directly (after adding the LTO profile option); i do not know enough where the LTO option from the PKGBUILD would be otherwise applied, that is why i asked if this is resolved now. |
|
just for testing (and because i could), i tested diff: diff --git a/PKGBUILD b/PKGBUILD
index f69bbc6..fb46cce 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -7,12 +7,11 @@ pkgdesc='Music Player TUI written in Rust'
arch=(x86_64)
url=https://github.com/tramhao/termusic
license=(GPL3 MIT)
-depends=(dbus gst-libav gst-plugins-bad gst-plugins-base gst-plugins-good gst-plugins-ugly gstreamer mpv protobuf ueberzug) # alsa-lib libmpv.so
+depends=(dbus gst-libav gst-plugins-bad gst-plugins-base gst-plugins-good gst-plugins-ugly gstreamer mpv protobuf) # alsa-lib libmpv.so
makedepends=(cargo git)
optdepends=('ffmpeg: extract audio by downloader' 'yt-dlp: download files')
provides=("${pkgname%-git}")
conflicts=("${pkgname%-git}")
-options=(!lto)
source=("$pkgname::git+$url.git")
sha256sums=(SKIP)if the problem still persists for you, please explain more where it fails and what the error is and what your system is |
|
So, I stumbled upon here, getting the same issue when Here's the exact log of what happens: From what I can try to understand reading it, it seems to stumble on the https://github.com/rqlite/rqlite crate, but I'm not expert in those questions. Disabling |
|
@Porkepix 50e64f0 is about two months old now, could you try some newer version? could you provide PS: also please note that i too am not am linking expert |
|
The build log is from HEAD (0.7.11.r356.gac006a8-1), it's just the error message at the end that's misleading and I didn't set the beginning of the logs before every rust compiling lines where it was showing it was building that version, my bad. As was visible from logs, rustc is latest, but here are full commands info if you want: As for running this manually fro cargo, I tried various ways but couldn't find one that was acting the same way (messages about experimental features and so on), nor could I find good documentation on the good way to do this. |
i dont quite know what this would be referencing. the simplest build i can imagine with rust's lto (assuming you have rust and the build dependencies installed): git clone https://github.com/tramhao/termusic.git --depth 10
cd termusic
# enable LTO (to my understanding)
sed -i -- "s/# lto = true/lto = true/" Cargo.toml
cargo build --release
# verify all binaries exist
ls -al target/release/{termusic,termusic-server}i dont know what the git clone https://aur.archlinux.org/termusic-git.git
cd termusic-git
# remove that dependency, as it does not exist for me
sed -i -- "s/ueberzug//" PKGBUILD
# explicitly enable lto
sed -i -- "s/options=(\!lto)/options=(lto)/" PKGBUILD
makepkgbut i dont know how to fix it, the best i could come up with if wanting to have some lto is to use the lto option in the cargo file: git clone https://aur.archlinux.org/termusic-git.git
cd termusic-git
# remove that dependency, as it does not exist for me
sed -i -- "s/ueberzug//" PKGBUILD
# get source
makepkg -o
# enable rust's lto
sed -i -- "s/# lto = true/lto = true/" src/termusic-git/Cargo.toml
# build without resetting source (and so not undoing the sed)
makepkg -e |
I'm not the maintainer of arch packages. |
|
It may depend on if you merged the new version of this file: https://gitlab.archlinux.org/archlinux/packaging/packages/pacman/-/blob/main/makepkg.conf?ref_type=heads from the I have two other rust packages affected (one of them have When I was looking for ways to have |
if you mean |
ghost
closed this as
|
@LuisB79 Why close when the issue is still around ? And why removing the title? |
|
It looks like the user was deleted, so maybe it was automatic? In any case, termusic does not maintain the termusic arch linux package nor the termusic-git aur package, so discussion should likely either happen there or be moved to a discussion. |
@hasezoey It looks curious, I don't see why a user removal of an account that's not the author should close the issue, even less rename the title to a dash…? As for the issue itself, I'm well aware that the I mean, yes it's new build defaults on ArchLinux, but those are well supported by Rust and shouldn't have this result, right? |
I dont know what github will do, though from what i can tell, it was the author that got deleted? (at least the original comment shows as
Yes i could reproduce the issue when building with a makepkg file and arch's lto, but i dont know enough to fix it and rust's own lto works just fine from my testing. Also btw #149 (comment) was about having tried changing the lto options in rust while arch's lto was also enabled to see if there was a issue with a specific kind ( |
Uh oh, I reported several similar issues on other projects (two or three others) and somehow forgot I wasn't the one who did here, that it was done by someone else before. My bad.
Could this still be reopened then and at the very least set the title back to something meaningful? (I find it absurd they remove the title if we can still read every message in it…) As for the issue itself, would @tramhao have better ideas about this? Is it something that should be investigated/discussed with people from Rust (I believe they moved to a closed platform where I'm not, though) or with those from ArchLinux? |
I agree with changing the title back, but i do not have the power to do so (dont have Triage or Write permissions). @tramhao could you change it back?
Likely depends on where you wanna file the issue, IIRC they have a Zulip where you could ask. |
My bad, I thought you had more permissions.
Didn't they (unfortunately) move to Discord? I looked at this Zulip and have no idea where that would be asking, I'm not used to this. What I'd like to also know is what the EDIT: Also, stumbled upon https://gitlab.archlinux.org/archlinux/packaging/packages/pacman/-/issues/20 |
I guess i missed them creating a discord, though from what i can see |
This issue was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: